r54971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54970‎ | r54971 | r54972 >
Date:21:18, 13 August 2009
Author:aaron
Status:ok
Tags:
Comment:
Follow-up r54966: more sanity checks
Modified paths:
  • /trunk/phase3/includes/Cdb.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Cdb.php
@@ -98,7 +98,8 @@
9999 }
100100
101101 function close() {
102 - dba_close( $this->handle );
 102+ if( isset($this->handle) )
 103+ dba_close( $this->handle );
103104 unset( $this->handle );
104105 }
105106
@@ -128,7 +129,8 @@
129130 }
130131
131132 function close() {
132 - dba_close( $this->handle );
 133+ if( isset($this->handle) )
 134+ dba_close( $this->handle );
133135 if ( wfIsWindows() ) {
134136 unlink( $this->realFileName );
135137 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54966Sanity check $this->handle on close()aaron20:42, 13 August 2009

Status & tagging log