r54960 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54959‎ | r54960 | r54961 >
Date:18:51, 13 August 2009
Author:brion
Status:deferred
Tags:
Comment:
add fixme comment -- local branch dir is forced onto the subversion base URL, making it impossible for this extension to do what it's meant to do (pull localization updates from trunk and run them on a deployment)
Modified paths:
  • /trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LocalisationUpdate/LocalisationUpdate.class.php
@@ -41,6 +41,8 @@
4242 global $IP, $wgLocalisationUpdateSVNURL;
4343
4444 // Find the right SVN folder
 45+ // @fixme this prevents pulling trunk updates when we're on a deployment branch.
 46+ // Base URL should be fully configurable and make no branch assumptions.
4547 $svnFolder = SpecialVersion::getSvnRevision( dirname( $file ), false, false, true );
4648
4749 // Create a full path

Status & tagging log