r54958 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54957‎ | r54958 | r54959 >
Date:18:39, 13 August 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.3.
Modified paths:
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayers.php (modified) (history)
  • /trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMaps.php
@@ -68,9 +68,11 @@
6969 foreach ($this->m_locations as $location) {
7070 // Create a string containing the marker JS
7171 list($lat, $lon, $title, $label, $icon) = $location;
 72+
7273 $title = str_replace("'", "\'", $title);
7374 $label = str_replace("'", "\'", $label);
74 - $markerItems[] = "getYMarkerData($lat, $lon, '$title', '$label', '')";
 75+
 76+ $markerItems[] = "getYMarkerData($lat, $lon, '$title', '$label', '$icon')";
7577 }
7678
7779 $markersString = implode(',', $markerItems);
Index: trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayers.php
@@ -68,9 +68,11 @@
6969 foreach ($this->m_locations as $location) {
7070 // Create a string containing the marker JS
7171 list($lat, $lon, $title, $label, $icon) = $location;
 72+
7273 $title = str_replace("'", "\'", $title);
7374 $label = str_replace("'", "\'", $label);
74 - $markerItems[] = "getOLMarkerData($lon, $lat, '$title', '$label')";
 75+
 76+ $markerItems[] = "getOLMarkerData($lon, $lat, '$title', '$label', '$icon')";
7577 }
7678
7779 $markersString = implode(',', $markerItems);
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMaps.php
@@ -75,8 +75,10 @@
7676 foreach ($this->m_locations as $location) {
7777 // Create a string containing the marker JS
7878 list($lat, $lon, $title, $label, $icon) = $location;
 79+
7980 $title = str_replace("'", "\'", $title);
8081 $label = str_replace("'", "\'", $label);
 82+
8183 $markerItems[] = "getGMarkerData($lat, $lon, '$title', '$label', '$icon')";
8284 }
8385

Status & tagging log