r54849 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54848‎ | r54849 | r54850 >
Date:13:58, 12 August 2009
Author:ashley
Status:deferred
Tags:
Comment:
SocialProfile:
*js cleanup
*UserBoard fixes
*i18n tweaks
Modified paths:
  • /trunk/extensions/SocialProfile/UserBoard/BoardBlast.js (modified) (history)
  • /trunk/extensions/SocialProfile/UserBoard/SpecialSendBoardBlast.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserBoard/SpecialUserBoard.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/UserProfile.i18n.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/UserProfilePage.js (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/UserProfilePage.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserRelationship/UserRelationship.js (modified) (history)
  • /trunk/extensions/SocialProfile/UserStats/UserStats.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserBoard/BoardBlast.js
@@ -1,89 +1,90 @@
2 -function toggle_user(user_id){
3 - if ($D.hasClass("user-" + user_id ,'blast-friend-selected')){
4 - $D.replaceClass("user-" + user_id,'blast-friend-selected','blast-friend-unselected');
5 - }else if ($D.hasClass("user-" + user_id ,'blast-friend-unselected')){
6 - $D.replaceClass("user-" + user_id,'blast-friend-unselected','blast-friend-selected');
 2+function toggle_user( user_id ){
 3+ if( YAHOO.util.Dom.hasClass( 'user-' + user_id, 'blast-friend-selected' ) ){
 4+ YAHOO.util.Dom.replaceClass( 'user-' + user_id, 'blast-friend-selected', 'blast-friend-unselected' );
 5+ } else if( YAHOO.util.Dom.hasClass( 'user-' + user_id, 'blast-friend-unselected' ) ){
 6+ YAHOO.util.Dom.replaceClass( 'user-' + user_id, 'blast-friend-unselected', 'blast-friend-selected' );
77 }
88
9 - if ($D.hasClass("user-" + user_id ,'blast-foe-selected')){
10 - $D.replaceClass("user-" + user_id,'blast-foe-selected','blast-foe-unselected');
11 - }else if ($D.hasClass("user-" + user_id ,'blast-foe-unselected')){
12 - $D.replaceClass("user-" + user_id,'blast-foe-selected','blast-foe-unselected');
 9+ if( YAHOO.util.Dom.hasClass( 'user-' + user_id, 'blast-foe-selected' ) ){
 10+ YAHOO.util.Dom.replaceClass( 'user-' + user_id, 'blast-foe-selected', 'blast-foe-unselected' );
 11+ } else if( YAHOO.util.Dom.hasClass( 'user-' + user_id, 'blast-foe-unselected' ) ){
 12+ YAHOO.util.Dom.replaceClass( 'user-' + user_id, 'blast-foe-selected', 'blast-foe-unselected' );
1313 }
1414 }
1515
16 -function toggle_type(method,on,off){
17 - list = $$( ((method==1)?off:on) ,'div','blast-friends-list')
 16+function toggle_type( method, on, off ){
 17+ list = YAHOO.util.Dom.getElementsByClassName( ( ( method == 1 ) ? off : on ), 'div', 'blast-friends-list' );
1818
19 - for(x=0;x<=list.length-1;x++){
 19+ for( x = 0; x <= list.length-1; x++ ){
2020 el = list[x];
21 - if($D.hasClass(el,on) || $D.hasClass(el,off)){
22 - if(method==1){
23 - $D.replaceClass(el,off,on);
24 - }else{
25 - $D.replaceClass(el,on,off);
 21+ if( YAHOO.util.Dom.hasClass( el, on ) || YAHOO.util.Dom.hasClass( el, off ) ){
 22+ if( method == 1 ){
 23+ YAHOO.util.Dom.replaceClass( el, off, on );
 24+ } else {
 25+ YAHOO.util.Dom.replaceClass( el, on, off );
2626 }
2727 }
2828 }
2929 }
3030
31 -function toggle_friends(method){
32 - toggle_type(method,'blast-friend-selected','blast-friend-unselected')
 31+function toggle_friends( method ){
 32+ toggle_type( method, 'blast-friend-selected', 'blast-friend-unselected' );
3333 }
3434
35 -function toggle_foes(method){
36 - toggle_type(method,'blast-foe-selected','blast-foe-unselected')
 35+function toggle_foes( method ){
 36+ toggle_type( method, 'blast-foe-selected', 'blast-foe-unselected' );
3737 }
3838
3939 function select_all(){
40 - toggle_friends(1)
41 - toggle_foes(1)
 40+ toggle_friends( 1 );
 41+ toggle_foes( 1 );
4242 }
4343 function unselect_all(){
44 - toggle_friends(0)
45 - toggle_foes(0)
 44+ toggle_friends( 0 );
 45+ toggle_foes( 0 );
4646 }
4747
4848 submitted = 0;
49 -function send_messages( ){
50 - if(submitted == 1) return 0;
 49+function send_messages(){
 50+ if( submitted == 1 )
 51+ return 0;
5152
5253 submitted = 1
5354 selected = 0;
54 - user_ids_to = "";
 55+ user_ids_to = '';
5556
56 - list = $$('blast-friend-selected','div','blast-friends-list')
57 - for(x=0;x<=list.length-1;x++){
 57+ list = YAHOO.util.Dom.getElementsByClassName( 'blast-friend-selected', 'div', 'blast-friends-list' );
 58+ for( x = 0; x <= list.length-1; x++ ){
5859 el = list[x];
5960 selected++;
60 - user_id = el.id.replace("user-","");
61 - user_ids_to += ((user_ids_to)?",":"") + user_id
 61+ user_id = el.id.replace( 'user-', '' );
 62+ user_ids_to += ( ( user_ids_to ) ? ',' : '' ) + user_id;
6263 }
6364
64 - list = $$('blast-foe-selected','div','blast-friends-list')
65 - for(x=0;x<=list.length-1;x++){
 65+ list = YAHOO.util.Dom.getElementsByClassName( 'blast-foe-selected', 'div', 'blast-friends-list' );
 66+ for( x = 0; x <= list.length-1; x++ ){
6667 el = list[x];
6768 selected++;
68 - user_id = el.id.replace("user-","");
69 - user_ids_to += ((user_ids_to)?",":"") + user_id
 69+ user_id = el.id.replace( 'user-', '' );
 70+ user_ids_to += ( ( user_ids_to ) ? ',' : '' ) + user_id;
7071 }
7172
72 - if(selected==0){
73 - alert("Please select at least one person");
 73+ if( selected == 0 ){
 74+ alert('Please select at least one person');
7475 submitted = 0;
7576 return 0;
7677 }
7778
78 - if( !$("message").value ){
79 - alert("Please enter a message");
 79+ if( !document.getElementById('message').value ){
 80+ alert('Please enter a message');
8081 submitted = 0;
8182 return 0;
8283 }
8384
84 - $("ids").value = user_ids_to;
 85+ document.getElementById('ids').value = user_ids_to;
8586
8687 document.blast.message.style.color = "#ccc";
8788 document.blast.message.readOnly = true;
88 - $("blast-friends-list").innerHTML = 'Sending messages...';
 89+ document.getElementById('blast-friends-list').innerHTML = 'Sending messages...';
8990 document.blast.submit();
9091 }
Index: trunk/extensions/SocialProfile/UserBoard/SpecialUserBoard.php
@@ -1,5 +1,5 @@
22 <?php
3 -if ( ! defined( 'MEDIAWIKI' ) )
 3+if ( !defined( 'MEDIAWIKI' ) )
44 die();
55 /**
66 * Display User Board messages for a user
@@ -28,12 +28,12 @@
2929 * @param $params Mixed: parameter(s) passed to the page or null
3030 */
3131 public function execute( $params ) {
32 - global $wgUser, $wgOut, $wgRequest, $wgMemc, $wgScriptPath, $wgUserBoardScripts;
 32+ global $wgUser, $wgOut, $wgRequest, $wgScriptPath, $wgUserBoardScripts;
3333
3434 wfLoadExtensionMessages( 'SocialProfileUserBoard' );
3535
3636 // Add CSS
37 - $wgOut->addStyle( '../..' . $wgUserBoardScripts . '/UserBoard.css' );
 37+ $wgOut->addExtensionStyle( $wgUserBoardScripts . '/UserBoard.css' );
3838
3939 $ub_messages_show = 25;
4040 $user_name = $wgRequest->getVal( 'user' );
@@ -54,7 +54,8 @@
5555 /**
5656 * If no user is set in the URL, we assume its the current user
5757 */
58 - if ( !$user_name ) $user_name = $wgUser->getName();
 58+ if ( !$user_name )
 59+ $user_name = $wgUser->getName();
5960 $user_id = User::idFromName( $user_name );
6061 $user = Title::makeTitle( NS_USER, $user_name );
6162 $user_safe = str_replace( '&', '%26', $user_name );
@@ -110,47 +111,38 @@
111112 $output .= '<a href="' . $user->escapeFullURL() . '">&lt; ' . wfMsg( 'userboard_backprofile', $user_name ) . '</a>';
112113 $output .= '</div>';
113114 $output .= "<script type=\"text/javascript\">/*<![CDATA[*/
114 - var _DELETE_CONFIRM = \"" . wfMsg( 'userboard_confirmdelete' ) . "\"
 115+ var _DELETE_CONFIRM = \"" . wfMsg( 'userboard_confirmdelete' ) . "\";
115116 var posted = 0;
116117 function send_message(){
117 - if(\$(\"message\").value && !posted){
 118+ if( document.getElementById('message').value && !posted ){
118119 posted = 1;
119 - var url = \"index.php?action=ajax\";
120 - var pars = 'rs=wfSendBoardMessage&rsargs[]=' + encodeURIComponent(\$(\"user_name_to\").value) +'&rsargs[]=' + encodeURIComponent(\$(\"message\").value) + '&rsargs[]=' + \$(\"message_type\").value + '&rsargs[]={$per_page}'
121 -
122 - var callback = {
123 - success: function(originalRequest){
 120+ encodedName = encodeURIComponent( document.getElementById('user_name_to').value );
 121+ encodedMsg = encodeURIComponent( document.getElementById('message').value );
 122+ sajax_request_type = 'POST';
 123+ sajax_do_call( 'wfSendBoardMessage', [ encodedName, encodedMsg, {$per_page} ], function( originalRequest ){
124124 posted = 0;
125 - if(\$(\"user_name_from\").value){ //its a board to board
126 - user_1 = \$(\"user_name_from\").value
127 - user_2 = \$(\"user_name_to\").value
 125+ if( document.getElementById('user_name_from').value ){ //its a board to board
 126+ user_1 = document.getElementById('user_name_from').value;
 127+ user_2 = document.getElementById('user_name_to').value;
128128 } else {
129 - user_1 = \$(\"user_name_to\").value
130 - user_2 = \"\";
 129+ user_1 = document.getElementById('user_name_to').value;
 130+ user_2 = '';
131131 }
132 - //user_1 = escape(user_1);
133 - //user_2 = escape(user_2);
134 - var params = (user_2) ? '&conv=' + user_2 : '';
 132+ var params = ( user_2 ) ? '&conv=' + user_2 : '';
135133 var url = wgScriptPath + '/index.php?title=Special:UserBoard&user=' + user_1 + params;
136134 window.location = url;
137135 }
138 - };
139 - var request = YAHOO.util.Connect.asyncRequest('POST', url, callback, pars);
140 -
 136+ );
141137 }
142138 }
143 - function delete_message(id){
 139+
 140+ function delete_message( id ){
144141 if( confirm( _DELETE_CONFIRM ) ){
145 - var url = \"index.php?action=ajax\";
146 - var pars = 'rs=wfDeleteBoardMessage&rsargs[]=' + id
147 - var callback = {
148 - success: function(originalRequest){
149 - window.location.reload();
150 - }
151 - };
152 - var request = YAHOO.util.Connect.asyncRequest('POST', url, callback, pars);
 142+ sajax_request_type = 'POST';
 143+ sajax_do_call( 'wfDeleteBoardMessage', [ id ], function( originalRequest ){
 144+ window.location.reload();
 145+ });
153146 }
154 -
155147 }
156148 /*]]>*/</script>";
157149
@@ -246,7 +238,7 @@
247239 <textarea name="message" id="message" cols="63" rows="4"/></textarea>
248240
249241 <div class="user-page-message-box-button">
250 - <input type="button" value="' . wfMsg( 'userboard_sendbutton' ) . '" class="site-button" onclick="javascript:send_message();">
 242+ <input type="button" value="' . wfMsg( 'userboard_sendbutton' ) . '" class="site-button" onclick="javascript:send_message();" />
251243 </div>
252244
253245 </div>';
Index: trunk/extensions/SocialProfile/UserBoard/SpecialSendBoardBlast.php
@@ -24,10 +24,10 @@
2525 * @param $params Mixed: parameter(s) passed to the page or null
2626 */
2727 public function execute( $params ) {
28 - global $wgRequest, $wgOut, $wgUser, $IP, $wgUserBoardScripts;
 28+ global $wgRequest, $wgOut, $wgUser, $wgUserBoardScripts;
2929
3030 // Add CSS & JS
31 - $wgOut->addStyle( '../..' . $wgUserBoardScripts . '/BoardBlast.css' );
 31+ $wgOut->addExtensionStyle( $wgUserBoardScripts . '/BoardBlast.css' );
3232 $wgOut->addScriptFile( $wgUserBoardScripts . '/BoardBlast.js' );
3333
3434 wfLoadExtensionMessages( 'SocialProfileUserBoard' );
@@ -36,18 +36,18 @@
3737
3838 // This feature is available only to logged-in users.
3939 if ( !$wgUser->isLoggedIn() ) {
40 - $wgOut->setPageTitle( wfMsgForContent( 'boardblastlogintitle' ) );
41 - $output = wfMsgForContent( 'boardblastlogintext' );
 40+ $wgOut->setPageTitle( wfMsg( 'boardblastlogintitle' ) );
 41+ $output = wfMsg( 'boardblastlogintext' );
4242 $wgOut->addHTML( $output );
4343 return '';
4444 }
4545
4646 if ( $wgRequest->wasPosted() ) {
47 - $wgOut->setPagetitle( wfMsgForContent( 'messagesenttitle' ) );
 47+ $wgOut->setPageTitle( wfMsg( 'messagesenttitle' ) );
4848 $b = new UserBoard();
4949
5050 $count = 0;
51 - $user_ids_to = explode( ",", $wgRequest->getVal( 'ids' ) );
 51+ $user_ids_to = explode( ',', $wgRequest->getVal( 'ids' ) );
5252 foreach ( $user_ids_to as $user_id ) {
5353 $user = User::newFromId( $user_id );
5454 $user->loadFromId();
@@ -55,9 +55,9 @@
5656 $b->sendBoardMessage( $wgUser->getID(), $wgUser->getName(), $user_id, $user_name, $wgRequest->getVal( 'message' ), 1 );
5757 $count++;
5858 }
59 - $output .= wfMsgForContent( 'messagesentsuccess' );
 59+ $output .= wfMsg( 'messagesentsuccess' );
6060 } else {
61 - $wgOut->setPagetitle( wfMsgForContent( 'boardblasttitle' ) );
 61+ $wgOut->setPageTitle( wfMsg( 'boardblasttitle' ) );
6262 $output .= $this->displayForm();
6363 }
6464
@@ -76,29 +76,29 @@
7777 wfLoadExtensionMessages( 'SocialProfileUserBoard' );
7878
7979 $output = '<div class="board-blast-message-form">
80 - <h2>' . wfMsgForContent( 'boardblaststep1' ) . '</h2>
 80+ <h2>' . wfMsg( 'boardblaststep1' ) . '</h2>
8181 <form method="post" name="blast" action="">
82 - <input type="hidden" name="ids" id="ids">
 82+ <input type="hidden" name="ids" id="ids" />
8383 <div class="blast-message-text">
84 - ' . wfMsgForContent( 'boardblastprivatenote' ) . '
 84+ ' . wfMsg( 'boardblastprivatenote' ) . '
8585 </div>
8686 <textarea name="message" id="message" cols="63" rows="4"/></textarea>
8787 </form>
8888 </div>
8989 <div class="blast-nav">
90 - <h2>' . wfMsgForContent( 'boardblaststep2' ) . '</h2>
 90+ <h2>' . wfMsg( 'boardblaststep2' ) . '</h2>
9191 <div class="blast-nav-links">
92 - <a href="javascript:void(0);" onclick="javascript:select_all()">' . wfMsgForContent( 'boardlinkselectall' ) . '</a> -
93 - <a href="javascript:void(0);" onclick="javascript:unselect_all()">' . wfMsgForContent( 'boardlinkunselectall' ) . '</a> ';
 92+ <a href="javascript:void(0);" onclick="javascript:select_all()">' . wfMsg( 'boardlinkselectall' ) . '</a> -
 93+ <a href="javascript:void(0);" onclick="javascript:unselect_all()">' . wfMsg( 'boardlinkunselectall' ) . '</a> ';
9494
9595 if ( $stats_data['friend_count'] > 0 && $stats_data['foe_count'] > 0 ) {
96 - $output .= '- <a href="javascript:void(0);" onclick="javascript:toggle_friends(1)">' . wfMsgForContent( 'boardlinkselectfriends' ) . '</a> -';
97 - $output .= '<a href="javascript:void(0);" onclick="javascript:toggle_friends(0)">' . wfMsgForContent( 'boardlinkunselectfriends' ) . '</a>';
 96+ $output .= '- <a href="javascript:void(0);" onclick="javascript:toggle_friends(1)">' . wfMsg( 'boardlinkselectfriends' ) . '</a> -';
 97+ $output .= '<a href="javascript:void(0);" onclick="javascript:toggle_friends(0)">' . wfMsg( 'boardlinkunselectfriends' ) . '</a>';
9898 }
9999
100100 if ( $stats_data['foe_count'] > 0 && $stats_data['friend_count'] > 0 ) {
101 - $output .= '- <a href="javascript:void(0);" onclick="javascript:toggle_foes(1)">' . wfMsgForContent( 'boardlinkselectfoes' ) . '</a> -';
102 - $output .= '<a href="javascript:void(0);" onclick="javascript:toggle_foes(0)">' . wfMsgForContent( 'boardlinkunselectfoes' ) . '</a>';
 101+ $output .= '- <a href="javascript:void(0);" onclick="javascript:toggle_foes(1)">' . wfMsg( 'boardlinkselectfoes' ) . '</a> -';
 102+ $output .= '<a href="javascript:void(0);" onclick="javascript:toggle_foes(0)">' . wfMsg( 'boardlinkunselectfoes' ) . '</a>';
103103 }
104104 $output .= '</div>
105105 </div>';
@@ -115,11 +115,12 @@
116116 $output .= "<div class=\"blast-" . ( ( $relationship['type'] == 1 ) ? 'friend' : 'foe' ) . "-unselected\" id=\"user-{$relationship["user_id"]}\" onclick=\"javascript:toggle_user({$relationship["user_id"]})\">
117117 {$relationship["user_name"]}
118118 </div>";
119 - if ( $x == count( $relationships ) || $x != 1 && $x % $per_row == 0 ) $output .= '<div class="cleared"></div>';
 119+ if ( $x == count( $relationships ) || $x != 1 && $x % $per_row == 0 )
 120+ $output .= '<div class="cleared"></div>';
120121 $x++;
121122 }
122123 } else {
123 - $output .= '<div>' . wfMsgForContent( 'boardnofriends' ) . '</div>';
 124+ $output .= '<div>' . wfMsg( 'boardnofriends' ) . '</div>';
124125 }
125126
126127 $output .= '</div>
@@ -127,7 +128,7 @@
128129 <div class="cleared"></div>';
129130
130131 $output .= '<div class="blast-message-box-button">
131 - <input type="button" value="' . wfMsgForContent( 'boardsendbutton' ) . '" class="site-button" onclick="javascript:send_messages();">
 132+ <input type="button" value="' . wfMsg( 'boardsendbutton' ) . '" class="site-button" onclick="javascript:send_messages();" />
132133 </div>';
133134 return $output;
134135 }
Index: trunk/extensions/SocialProfile/UserStats/UserStats.i18n.php
@@ -620,17 +620,17 @@
621621 'top-fans-monthly-points-link' => 'Pisteitä tässä kuussa',
622622 'top-fans-points' => 'pistettä',
623623 'top-fans-bad-field-title' => 'Ups!',
624 - 'top-fans-stats-vote-count' => '{{PLURAL:$1|Ääni|Ääniä}}',
 624+ 'top-fans-stats-vote-count' => '{{PLURAL:$1|ääni|ääniä}}',
625625 'top-fans-stats-monthly-winner-count' => '{{PLURAL:$1|kuukausittainen voitto|kuukausittaista voittoa}}',
626626 'top-fans-stats-weekly-winner-count' => '{{PLURAL:$1|viikottainen voitto|viikottaista voittoa}}',
627627 'top-fans-stats-edit-count' => '{{PLURAL:$1|muokkaus|muokkausta}}',
628628 'top-fans-stats-comment-count' => '{{PLURAL:$1|kommentti|kommenttia}}',
629629 'top-fans-stats-friends-count' => '{{PLURAL:$1|ystävä|ystävää}}',
630630 'top-fans-stats-foe-count' => '{{PLURAL:$1|vihollinen|vihollista}}',
631 - 'top-fans-stats-opinions-published' => '{{PLURAL:$1|Julkaistu mielipide|Julkaistut mielipiteet}}',
632 - 'top-fans-stats-opinions-created' => '{{PLURAL:$1|Mielipide|Mielipiteet}}',
633 - 'top-fans-stats-comment-score-positive-rec' => '{{PLURAL:$1|Peukalo ylös|Peukalot ylös}}',
634 - 'top-fans-stats-comment-score-negative-rec' => '{{PLURAL:$1|Peukalo alas|Peukalot alas}}',
 631+ 'top-fans-stats-opinions-published' => '{{PLURAL:$1|julkaistu mielipide|julkaistua mielipidettä}}',
 632+ 'top-fans-stats-opinions-created' => '{{PLURAL:$1|mielipide|mielipidettä}}',
 633+ 'top-fans-stats-comment-score-positive-rec' => '{{PLURAL:$1|peukalo ylös|peukaloa ylös}}',
 634+ 'top-fans-stats-comment-score-negative-rec' => '{{PLURAL:$1|peukalo alas|peukaloa alas}}',
635635 'top-fans-stats-gifts-rec-count' => '{{PLURAL:$1|saatu lahja|saatua lahjaa}}',
636636 'top-fans-stats-gifts-sent-count' => '{{PLURAL:$1|lähetetty lahja|lähetettyä lahjaa}}',
637637 'right-updatepoints' => 'Päivittää muokkausmääriä',
Index: trunk/extensions/SocialProfile/UserProfile/UserProfilePage.php
@@ -640,7 +640,7 @@
641641 $avatar_img = '<img src="' . $wgUploadPath . '/avatars/' . $avatar->getAvatarImage() . '" alt="" border="0" />';
642642
643643 // Chop down username that gets displayed
644 - $user_name = substr( $friend['user_name'], 0, 9 );
 644+ $user_name = mb_substr( $friend['user_name'], 0, 9 );
645645 if ( $user_name != $friend['user_name'] ) $user_name .= '..';
646646
647647 $output .= "<a href=\"" . $user->escapeFullURL() . "\" title=\"{$friend["user_name"]}\" rel=\"nofollow\">
Index: trunk/extensions/SocialProfile/UserProfile/UserProfile.i18n.php
@@ -2967,7 +2967,6 @@
29682968 /** Finnish (Suomi)
29692969 * @author Cimon Avaro
29702970 * @author Crt
2971 - * @author Jack Phoenix
29722971 * @author Jack Phoenix <jack@countervandalism.net>
29732972 * @author Str4nd
29742973 */
@@ -2999,7 +2998,6 @@
30002999 'user-friends-title' => 'Ystävät',
30013000 'user-foes-title' => 'Viholliset',
30023001 'other-info-movies' => 'Elokuvat',
3003 - 'other-info-tv' => 'tv',
30043002 'other-info-music' => 'Musiikki',
30053003 'other-info-books' => 'Kirjat',
30063004 'other-info-video-games' => 'Videopelit',
@@ -3073,7 +3071,6 @@
30743072 'user-profile-personal-websites' => 'Nettisivut',
30753073 'user-profile-interests-entertainment' => 'Viihde',
30763074 'user-profile-interests-movies' => 'Elokuvat',
3077 - 'user-profile-interests-tv' => 'tv',
30783075 'user-profile-interests-music' => 'Musiikki',
30793076 'user-profile-interests-books' => 'Kirjat',
30803077 'user-profile-interests-magazines' => 'Lehdet',
Index: trunk/extensions/SocialProfile/UserProfile/UserProfilePage.js
@@ -34,7 +34,8 @@
3535 var oldHtml = '';
3636
3737 function showUploadFrame(){
38 - new YAHOO.widget.Effects.Show('upload-container');
 38+ document.getElementById( 'upload-container' ).style['display'] = 'block';
 39+ document.getElementById( 'upload-container' ).style['visibility'] = 'visible';
3940 }
4041
4142 function uploadError( message ){
@@ -42,16 +43,19 @@
4344 document.getElementById('upload-frame-errors').innerHTML = message;
4445 document.getElementById('imageUpload-frame').src = 'index.php?title=Special:MiniAjaxUpload&wpThumbWidth=75';
4546
46 - new YAHOO.widget.Effects.Show('upload-container');
 47+ document.getElementById( 'upload-container' ).style['display'] = 'block';
 48+ document.getElementById( 'upload-container' ).style['visibility'] = 'visible';
4749 }
4850
4951 function textError( message ){
50 - document.getElementById('upload-frame-errors').innerHTML = message;
51 - new YAHOO.widget.Effects.Show('upload-frame-errors');
 52+ document.getElementById( 'upload-frame-errors' ).innerHTML = message;
 53+ document.getElementById( 'upload-frame-errors' ).style['display'] = 'block';
 54+ document.getElementById( 'upload-frame-errors' ).style['visibility'] = 'visible';
5255 }
5356
5457 function completeImageUpload(){
55 - new YAHOO.widget.Effects.Hide('upload-frame-errors');
 58+ document.getElementById( 'upload-frame-errors' ).style['display'] = 'none';
 59+ document.getElementById( 'upload-frame-errors' ).style['visibility'] = 'hidden';
5660 document.getElementById('upload-frame-errors').innerHTML = '';
5761 oldHtml = document.getElementById('mini-gallery-' + replaceID).innerHTML;
5862
@@ -60,11 +64,12 @@
6165 }
6266 document.getElementById('mini-gallery-0').innerHTML = '<a><img height="75" width="75" src="http://images.wikia.com/common/wikiany/images/ajax-loader-white.gif" alt="" /></a>';
6367
64 - //new YAHOO.widget.Effects.Hide('mini-gallery-nopics');
6568 if( document.getElementById( 'no-pictures-containers' ) ) {
66 - new YAHOO.widget.Effects.Hide( 'no-pictures-containers' );
 69+ document.getElementById( 'no-pictures-containers' ).style['display'] = 'none';
 70+ document.getElementById( 'no-pictures-containers' ).style['visibility'] = 'hidden';
6771 }
68 - new YAHOO.widget.Effects.Show( 'pictures-containers' );
 72+ document.getElementById( 'pictures-containers' ).style['display'] = 'block';
 73+ document.getElementById( 'pictures-containers' ).style['visibility'] = 'visible';
6974 }
7075
7176 function uploadComplete( imgSrc, imgName, imgDesc ){
Index: trunk/extensions/SocialProfile/UserRelationship/UserRelationship.js
@@ -3,7 +3,8 @@
44 * Used on Special:ViewRelationshipRequests
55 */
66 function requestResponse( response, id ){
7 - YAHOO.widget.Effects.Hide( 'request_action_' + id );
 7+ document.getElementById( 'request_action_' + id ).style['display'] = 'none';
 8+ document.getElementById( 'request_action_' + id ).style['visibility'] = 'hidden';
89 sajax_request_type = 'POST';
910 sajax_do_call( 'wfRelationshipRequestResponse', [ response, id ], function( request ){
1011 document.getElementById( 'request_action_' + id ).innerHTML = request.responseText;

Status & tagging log