r54795 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54794‎ | r54795 | r54796 >
Date:18:03, 11 August 2009
Author:btongminh
Status:reverted (Comments)
Tags:
Comment:
(bug 20052) Watch checkbox on Special:Movepage is checked by default when the old or new page is being watched.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -277,8 +277,11 @@
278278 );
279279 }
280280
 281+ # Check the watch checkbox in case the watch parameter was given in the
 282+ # request, the preferences say so, or either the old or new title is
 283+ # being watched.
281284 $watchChecked = $this->watch || $wgUser->getBoolOption( 'watchmoves' )
282 - || $this->oldTitle->userIsWatching();
 285+ || $this->oldTitle->userIsWatching() || $this->newTitle->userIsWatching();
283286 $wgOut->addHTML( "
284287 <tr>
285288 <td></td>
Index: trunk/phase3/RELEASE-NOTES
@@ -197,6 +197,8 @@
198198 output by omitting some things like quotation marks where HTML 5 allows.
199199 * Added crop for inline images.
200200 * The description message in $wgExtensionCredits can be an array with parameters
 201+* (bug 20052) Watch checkbox on Special:Movepage is checked by default when the
 202+ old or new page is being watched.
201203
202204 === Bug fixes in 1.16 ===
203205

Follow-up revisions

RevisionCommit summaryAuthorDate
r54807Revert r54795: Didn't work as expected and don't have time to fix.btongminh20:46, 11 August 2009

Comments

#Comment by Nikerabbit (talk | contribs)   18:49, 11 August 2009

PHP Fatal error: Call to a member function userIsWatching() on a non-object in /var/www/w/includes/specials/SpecialMovepage.php on line 284

#Comment by Bryan (talk | contribs)   20:46, 11 August 2009

Reverted in r54807.

Status & tagging log