r54794 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54793‎ | r54794 | r54795 >
Date:17:50, 11 August 2009
Author:btongminh
Status:ok
Tags:
Comment:
(bug 20176) Fix login/logout links in skin CologneBlue. Linker::linkKnown should be passed a title, not a string.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/CologneBlue.php
@@ -130,8 +130,8 @@
131131
132132 function sysLinks() {
133133 global $wgUser, $wgLang, $wgContLang;
134 - $li = $wgContLang->specialPage( 'Userlogin' );
135 - $lo = $wgContLang->specialPage( 'Userlogout' );
 134+ $li = SpecialPage::getTitleFor( 'Userlogin' );
 135+ $lo = SpecialPage::getTitleFor( 'Userlogout' );
136136
137137 $rt = $this->mTitle->getPrefixedURL();
138138 if ( 0 == strcasecmp( urlencode( $lo ), $rt ) ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -404,6 +404,7 @@
405405 Special:RecentChangesLinked
406406 * Do not transform EXIF fields with pure text to avoid results like
407407 foo,bar@example,com
 408+* (bug 20176) Fix login/logout links in skin CologneBlue
408409
409410 == API changes in 1.16 ==
410411

Status & tagging log