r54743 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54742‎ | r54743 | r54744 >
Date:20:57, 10 August 2009
Author:tparscal
Status:ok
Tags:
Comment:
Swtiched back to using js2AddOnloadHook from jQuery directly (in response to r54663)
Modified paths:
  • /trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php
@@ -117,7 +117,7 @@
118118 $url = $this->getTitle()->getLinkUrl();
119119 $wgOut->addHTML( Xml::tags( 'script',
120120 array( 'type' => $wgJsMimeType ),
121 - "jQuery(document).ready(function() { jQuery.post( \"$url\", optInGetPOSTData() ); } );"
 121+ 'js2AddOnloadHook( function() { $j.post( "' . $url . '", optInGetPOSTData() ); } );'
122122 ) );
123123 } else if ( $wgRequest->getVal( 'opt' ) == 'feedback' ) {
124124 if ( $wgRequest->wasPosted() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r54752Merge a bunch of UsabilityInitiative fixes. This commit may mess up svn:merge...catrope22:12, 10 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54663OptIn: Fix browser+OS registration that got borked by r53990 and was commente...catrope15:00, 9 August 2009

Status & tagging log