r54690 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54689‎ | r54690 | r54691 >
Date:23:36, 9 August 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.3.
Modified paths:
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMaps.php
@@ -66,7 +66,7 @@
6767 // Get the Google Maps names for the control and map types
6868 $this->type = MapsGoogleMapsUtils::getGMapType($this->type, true);
6969
70 - $control = MapsGoogleMapsUtils::getGControlType($this->controls);
 70+ $this->controls = MapsGoogleMapsUtils::createControlsString($this->controls);
7171
7272 $this->autozoom = MapsGoogleMapsUtils::getAutozoomJSValue($this->autozoom);
7373
@@ -90,7 +90,7 @@
9191 <div id="$this->mapName" class="$this->class" style="$this->style" ></div>
9292 <script type="$wgJsMimeType"> /*<![CDATA[*/
9393 addLoadEvent(
94 - initializeGoogleMap('$this->mapName', $this->width, $this->height, $this->centre_lat, $this->centre_lon, $this->zoom, $this->type, [$typesString], new $control(), $this->autozoom, [$markersString])
 94+ initializeGoogleMap('$this->mapName', $this->width, $this->height, $this->centre_lat, $this->centre_lon, $this->zoom, $this->type, [$typesString], [$this->controls], $this->autozoom, [$markersString])
9595 );
9696 /*]]>*/ </script>
9797
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -66,7 +66,7 @@
6767
6868 $this->type = MapsGoogleMapsUtils::getGMapType($this->type, true);
6969
70 - $control = MapsGoogleMapsUtils::getGControlType($this->controls);
 70+ $this->controls = MapsGoogleMapsUtils::createControlsString($this->controls);
7171
7272 $this->types = explode(",", $this->types);
7373
@@ -76,7 +76,7 @@
7777 <div id='".$this->mapName."' class='".$this->class."'></div>
7878
7979 <script type='$wgJsMimeType'>/*<![CDATA[*/
80 - addLoadEvent(makeFormInputGoogleMap('$this->mapName', '$this->coordsFieldName', $this->width, $this->height, $this->centre_lat, $this->centre_lon, $this->zoom, $this->marker_lat, $this->marker_lon, $this->type, [$typesString], new $control(), $this->autozoom));
 80+ addLoadEvent(makeFormInputGoogleMap('$this->mapName', '$this->coordsFieldName', $this->width, $this->height, $this->centre_lat, $this->centre_lon, $this->zoom, $this->marker_lat, $this->marker_lon, $this->type, [$typesString], [$this->controls], $this->autozoom));
8181 window.unload = GUnload;
8282 /*]]>*/</script>";
8383 }

Status & tagging log