r54641 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54640‎ | r54641 | r54642 >
Date:20:47, 8 August 2009
Author:ialex
Status:ok
Tags:
Comment:
* (bug 20131) PHP Notice: Undfined index: page_latest in includes/ChangesList.php on line 476

Special:Recentchangeslinked now also selects the 'page_latest' field for users having the 'rollback' right, as Special:Recentchanges does
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchangeslinked.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchangeslinked.php
@@ -84,6 +84,11 @@
8585 $select[] = 'wl_user';
8686 $join_conds['watchlist'] = array( 'LEFT JOIN', "wl_user={$uid} AND wl_title=rc_title AND wl_namespace=rc_namespace" );
8787 }
 88+ if ( $wgUser->isAllowed( 'rollback' ) ) {
 89+ $tables[] = 'page';
 90+ $join_conds['page'] = array('LEFT JOIN', 'rc_cur_id=page_id');
 91+ $select[] = 'page_latest';
 92+ }
8893
8994 ChangeTags::modifyDisplayQuery( $tables, $select, $conds, $join_conds,
9095 $query_options, $opts['tagfilter'] );
Index: trunk/phase3/RELEASE-NOTES
@@ -404,6 +404,8 @@
405405 * (bug 19289) importDump.php can now handle bzip2 and 7zip
406406 * (bug 20103) Add after the link for "My Talk" a info with the number of the
407407 new messages for the user
 408+* (bug 20131) Fixed a PHP notice for users having the "rollback" right on
 409+ Special:RecentChangesLinked
408410
409411 == API changes in 1.16 ==
410412

Status & tagging log