r54602 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54601‎ | r54602 | r54603 >
Date:21:03, 7 August 2009
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Moved some things around to please Apple Dictionary... some more...
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -536,12 +536,12 @@
537537 <!-- /header -->
538538 <!-- panel -->
539539 <div id="panel" class="noprint">
 540+ <!-- logo -->
 541+ <div id="p-logo"><a style="background-image: url(<?php $this->text( 'logopath' ) ?>);" href="<?php echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" <?php echo $this->skin->tooltipAndAccesskey( 'p-logo' ) ?>></a></div>
 542+ <!-- /logo -->
540543 <?php $this->renderPortals( $this->data['sidebar'] ); ?>
541544 </div>
542545 <!-- /panel -->
543 - <!-- logo -->
544 - <div id="p-logo"><a style="background-image: url(<?php $this->text( 'logopath' ) ?>);" href="<?php echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" <?php echo $this->skin->tooltipAndAccesskey( 'p-logo' ) ?>></a></div>
545 - <!-- /logo -->
546546 <!-- footer -->
547547 <div id="footer">
548548 <?php foreach( $validFooterLinks as $category => $links ): ?>

Follow-up revisions

RevisionCommit summaryAuthorDate
r54742Merge some fixes to Vector skin from trunk:...brion20:57, 10 August 2009

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   21:04, 7 August 2009

Depends on r54601 (should have committed them together)

Status & tagging log