r54521 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54520‎ | r54521 | r54522 >
Date:13:57, 6 August 2009
Author:jojo
Status:deferred
Tags:
Comment:
always show "Show book" link
Modified paths:
  • /trunk/extensions/Collection/Collection.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.hooks.php
@@ -356,31 +356,28 @@
357357 );
358358
359359 $numArticles = CollectionSession::countArticles();
360 - if ( $numArticles > 0 ) {
361 - $html .= $sk->link(
362 - SpecialPage::getTitleFor( 'Book' ),
363 - Xml::element('img',
364 - array(
365 - 'src' => "$imagePath/silk-book_open.png",
366 - 'alt' => '',
367 - 'width' => '16',
368 - 'height' => '16',
369 - 'style' => 'vertical-align: text-bottom',
370 - )
 360+ $html .= $sk->link(
 361+ SpecialPage::getTitleFor( 'Book' ),
 362+ Xml::element('img',
 363+ array(
 364+ 'src' => "$imagePath/silk-book_open.png",
 365+ 'alt' => '',
 366+ 'width' => '16',
 367+ 'height' => '16',
 368+ 'style' => 'vertical-align: text-bottom',
371369 )
372 - . ' ' . wfMsgHtml( 'coll-show_collection' )
373 - . ' (' . wfMsgHtml( 'coll-n_pages', $numArticles ) . ')',
374 - array(
375 - 'rel' => 'nofollow',
376 - 'title' => wfMsg( 'coll-show_collection_tooltip' ),
377 - 'style' => 'margin-left: 10px',
378 - ),
379 - array(),
380 - array( 'known', 'noclasses' )
381 - );
382 - }
 370+ )
 371+ . ' ' . wfMsgHtml( 'coll-show_collection' )
 372+ . ' (' . wfMsgHtml( 'coll-n_pages', $numArticles ) . ')',
 373+ array(
 374+ 'rel' => 'nofollow',
 375+ 'title' => wfMsg( 'coll-show_collection_tooltip' ),
 376+ 'style' => 'margin-left: 10px',
 377+ ),
 378+ array(),
 379+ array( 'known', 'noclasses' )
 380+ );
383381
384 -
385382 return $html;
386383 }
387384

Status & tagging log