r54510 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54509‎ | r54510 | r54511 >
Date:09:45, 6 August 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
* <b>Notice</b>: Undefined variable: val2 in <b>/var/www/sandwiki/includes/specials/SpecialUpload.php</b> on line <b>741</b>
* Fixed regression from r54428
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -738,7 +738,7 @@
739739 $val = wfShorthandToInteger( ini_get( 'upload_max_filesize' ) );
740740 $maxUploadSize = '<div id="mw-upload-maxfilesize">' .
741741 wfMsgExt( 'upload-maxfilesize', array( 'parseinline', 'escapenoentities' ),
742 - $wgLang->formatSize( $val2 ) ) .
 742+ $wgLang->formatSize( $val ) ) .
743743 "</div>\n";
744744 //add a hidden filed for upload by url (uses the $wgMaxUploadSize var)
745745 if( UploadFromUrl::isEnabled() ){

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r54428Convert check to use wfShorthandToInteger()emufarmers04:27, 5 August 2009

Status & tagging log