r54352 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54351‎ | r54352 | r54353 >
Date:08:54, 4 August 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
Whitespace fixes
Modified paths:
  • /trunk/phase3/includes/media/GIF.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialExport.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/GIF.php
@@ -15,7 +15,7 @@
1616 if ( !isset($image->parsedGIFMetadata) )
1717 $image->parsedGIFMetadata = GIFMetadataExtractor::getMetadata( $filename );
1818
19 - return serialize($image->parsedGIFMetadata);
 19+ return serialize($image->parsedGIFMetadata);
2020
2121 }
2222
Index: trunk/phase3/includes/specials/SpecialExport.php
@@ -44,7 +44,7 @@
4545 $this->templates = $wgRequest->getCheck( 'templates' );
4646 $this->images = $wgRequest->getCheck( 'images' ); // Doesn't do anything yet
4747 $this->pageLinkDepth = $this->validateLinkDepth(
48 - $wgRequest->getIntOrNull( 'pagelink-depth' ) );
 48+ $wgRequest->getIntOrNull( 'pagelink-depth' ) );
4949 $nsindex = '';
5050
5151 if ( $wgRequest->getCheck( 'addcat' ) ) {
@@ -74,7 +74,7 @@
7575 */
7676 $nspages = $this->getPagesFromNamespace( $nsindex );
7777 if ( $nspages ) $page .= "\n" . implode( "\n", $nspages );
78 - }
 78+ }
7979 }
8080 else if( $wgRequest->wasPosted() && $par == '' ) {
8181 $page = $wgRequest->getText( 'pages' );
@@ -88,10 +88,10 @@
8989 $limit = $wgRequest->getInt( 'limit' );
9090 $dir = $wgRequest->getVal( 'dir' );
9191 $history = array(
92 - 'dir' => 'asc',
93 - 'offset' => false,
94 - 'limit' => $wgExportMaxHistory,
95 - );
 92+ 'dir' => 'asc',
 93+ 'offset' => false,
 94+ 'limit' => $wgExportMaxHistory,
 95+ );
9696 $historyCheck = $wgRequest->getCheck( 'history' );
9797 if ( $this->curonly ) {
9898 $history = WikiExporter::CURRENT;
@@ -147,7 +147,7 @@
148148 $wgOut->addWikiMsg( 'exporttext' );
149149
150150 $form = Xml::openElement( 'form', array( 'method' => 'post',
151 - 'action' => $this->getTitle()->getLocalUrl( 'action=submit' ) ) );
 151+ 'action' => $this->getTitle()->getLocalUrl( 'action=submit' ) ) );
152152 $form .= Xml::inputLabel( wfMsg( 'export-addcattext' ) , 'catname', 'catname', 40 ) . ' ';
153153 $form .= Xml::submitButton( wfMsg( 'export-addcat' ), array( 'name' => 'addcat' ) ) . '<br />';
154154
@@ -197,7 +197,7 @@
198198 foreach( explode( "\n", $page ) as $pageName ) {
199199 $pageName = trim( $pageName );
200200 $title = Title::newFromText( $pageName );
201 - if( $title && $title->getInterwiki() == '' && $title->getText() != '' ) {
 201+ if( $title && $title->getInterwiki() == '' && $title->getText() !== '' ) {
202202 // Only record each page once!
203203 $pageSet[$title->getPrefixedText()] = true;
204204 }

Status & tagging log