r54348 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54347‎ | r54348 | r54349 >
Date:08:27, 4 August 2009
Author:nikerabbit
Status:ok
Tags:
Comment:
Small style test and whitespace preserving for tm suggestions
Modified paths:
  • /trunk/extensions/Translate/Translate.css (modified) (history)
  • /trunk/extensions/Translate/TranslateEditAddons.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/Translate.css
@@ -49,6 +49,10 @@
5050 margin: 0px !important;
5151 }
5252
 53+.mw-sp-translate-edit-extra {
 54+ border-bottom: 1px solid black;
 55+}
 56+
5357 .mw-sp-translate-group {
5458 border: 0;
5559 margin: 0 3em 3em 3em;
Index: trunk/extensions/Translate/TranslateEditAddons.php
@@ -333,7 +333,7 @@
334334 if ( $s['target'] === $translation ) continue;
335335 $sugboxes[] = TranslateUtils::fieldset(
336336 wfMsgHtml( 'translate-edit-tmsug' , sprintf( '%.2f', $s['quality'] ) ),
337 - $s['target'],
 337+ TranslateUtils::convertWhiteSpaceToHTML( $s['target'] ),
338338 array( 'class' => 'mw-sp-translate-edit-tmsug', 'title' => $s['source'] )
339339 );
340340 }
@@ -346,6 +346,11 @@
347347 }
348348 }
349349
 350+ // Make the non-mandatory boxes a different group, for easy access
 351+ $boxes = array(
 352+ Xml::tags( 'div', array( 'class' => 'mw-sp-translate-edit-extra' ), implode( "\n\n", $boxes ) )
 353+ );
 354+
350355 // User provided documentation
351356 if ( $wgTranslateDocumentationLanguageCode ) {
352357 global $wgUser;

Status & tagging log