r54238 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54237‎ | r54238 | r54239 >
Date:21:34, 2 August 2009
Author:demon
Status:ok
Tags:
Comment:
Use buildConcat()
Modified paths:
  • /trunk/phase3/maintenance/namespaceDupes.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/namespaceDupes.php
@@ -203,7 +203,7 @@
204204 $titleSql = "TRIM(LEADING '$prefix:' FROM {$page}_title)";
205205 if( $ns == 0 ) {
206206 // An interwiki; try an alternate encoding with '-' for ':'
207 - $titleSql = "CONCAT('$prefix-',$titleSql)";
 207+ $titleSql = $this->db->buildConcat( array( "'$prefix-'", $titleSql ) );
208208 }
209209
210210 $sql = "SELECT {$page}_id AS id,
@@ -214,7 +214,7 @@
215215 WHERE {$page}_namespace=0
216216 AND {$page}_title LIKE '$likeprefix:%'";
217217
218 - $result = $this->db->query( $sql, 'NamespaceConflictChecker::getConflicts' );
 218+ $result = $this->db->query( $sql, __METHOD__ );
219219
220220 $set = array();
221221 while( $row = $this->db->fetchObject( $result ) ) {

Status & tagging log