r54200 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54199‎ | r54200 | r54201 >
Date:12:22, 2 August 2009
Author:mkroetzsch
Status:deferred
Tags:
Comment:
Support retrieval of all values of a property using Special:PageProperty with empty subject (Bug 13148)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialPageProperty.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialPageProperty.php
@@ -13,7 +13,7 @@
1414 * This special page for Semantic MediaWiki implements a
1515 * view on a object-relation pair, i.e. a page that shows
1616 * all the fillers of a property for a certain page.
17 - * This is typically used for overflow results from other
 17+ * This is typically used for overflow results from other
1818 * dynamic output pages.
1919 *
2020 * @ingroup SMWSpecialPage
@@ -65,10 +65,10 @@
6666
6767 wfLoadExtensionMessages('SemanticMediaWiki');
6868
69 - if (('' == $type) || ('' == $from)) { // No relation or subject given.
 69+ if (('' == $type)) { // No relation or subject given.
7070 $html .= wfMsg('smw_pp_docu') . "\n";
7171 } else { // everything is given
72 - $wgOut->setPagetitle($subject->getFullText() . ' ' . $property->getWikiValue());
 72+ $wgOut->setPagetitle( ($subject === NULL?'':$subject->getFullText() . ' ') . $property->getWikiValue());
7373 $options = new SMWRequestOptions();
7474 $options->limit = $limit+1;
7575 $options->offset = $offset;

Status & tagging log