r54062 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r54061‎ | r54062 | r54063 >
Date:00:56, 31 July 2009
Author:demon
Status:ok
Tags:
Comment:
Handle todo: Mediawiki::initialize() is now called Mediawiki::performRequestForTitle()
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)
  • /trunk/phase3/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
@@ -42,7 +42,6 @@
4343 /**
4444 * Initialization of ... everything
4545 * Performs the request too
46 - * FIXME: why is this crap called "initialize" when it performs everything?
4746 *
4847 * @param $title Title ($wgTitle)
4948 * @param $article Article
@@ -50,7 +49,7 @@
5150 * @param $user User
5251 * @param $request WebRequest
5352 */
54 - function initialize( &$title, &$article, &$output, &$user, $request ) {
 53+ function performRequestForTitle( &$title, &$article, &$output, &$user, $request ) {
5554 wfProfileIn( __METHOD__ );
5655
5756 $output->setTitle( $title );
Index: trunk/phase3/index.php
@@ -113,7 +113,7 @@
114114 $mediaWiki->setVal( 'UseExternalEditor', $wgUseExternalEditor );
115115 $mediaWiki->setVal( 'UsePathInfo', $wgUsePathInfo );
116116
117 -$mediaWiki->initialize( $wgTitle, $wgArticle, $wgOut, $wgUser, $wgRequest );
 117+$mediaWiki->performRequestForTitle( $wgTitle, $wgArticle, $wgOut, $wgUser, $wgRequest );
118118 $mediaWiki->finalCleanup( $wgDeferredUpdateList, $wgOut );
119119
120120 # Not sure when $wgPostCommitUpdateList gets set, so I keep this separate from finalCleanup

Status & tagging log