r53939 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53938‎ | r53939 | r53940 >
Date:14:15, 29 July 2009
Author:yaron
Status:deferred
Tags:
Comment:
Added form-edit-tab handling for new "Vector" skin in MW 1.16
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormEditTab.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormEditTab.php
@@ -99,6 +99,19 @@
100100 }
101101
102102 /**
 103+ * Function currently called only for the 'Vector' skin, added in
 104+ * MW 1.16 - will possibly be called for additional skins later
 105+ */
 106+ static function displayTab2($obj, $links) {
 107+ // the old '$content_actions' array is thankfully just a
 108+ // sub-array of this one
 109+ $views_links = $links['views'];
 110+ self::displayTab($obj, &$views_links);
 111+ $links['views'] = $views_links;
 112+ return true;
 113+ }
 114+
 115+ /**
103116 * The function called if we're in index.php (as opposed to one of the
104117 * special pages)
105118 */
Index: trunk/extensions/SemanticForms/includes/SF_GlobalFunctions.php
@@ -7,7 +7,7 @@
88
99 if ( !defined( 'MEDIAWIKI' ) ) die();
1010
11 -define('SF_VERSION','1.8');
 11+define('SF_VERSION','1.8.1');
1212
1313 $wgExtensionCredits['specialpage'][]= array(
1414 'path' => __FILE__,
@@ -34,6 +34,7 @@
3535 $wgHooks['LinkEnd'][] = 'SFLinkUtils::setBrokenLink';
3636 $wgHooks['UnknownAction'][] = 'SFFormEditTab::displayForm';
3737 $wgHooks['SkinTemplateTabs'][] = 'SFFormEditTab::displayTab';
 38+$wgHooks['SkinTemplateNavigation'][] = 'SFFormEditTab::displayTab2';
3839 $wgHooks['smwInitProperties'][] = 'SFUtils::initProperties';
3940 $wgHooks['AdminLinks'][] = 'sffAddToAdminLinks';
4041

Status & tagging log