r53919 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53918‎ | r53919 | r53920 >
Date:01:10, 29 July 2009
Author:brion
Status:ok
Tags:
Comment:
* (bug 19957) All known-failing tests now marked disabled; added --run-disabled option to parser test suite to run disabled tests if desired.
Based on Dan Nessett's patch set.
I put back one of the test cases which does, in fact, work at least on my config. :)
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)
  • /trunk/phase3/maintenance/parserTests.php (modified) (history)
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
——@@ -25,7 +25,7 @@
2626 */
2727
2828 /** */
29 -$options = array( 'quick', 'color', 'quiet', 'help', 'show-output', 'record' );
 29+$options = array( 'quick', 'color', 'quiet', 'help', 'show-output', 'record'. 'run-disabled' );
3030 $optionsWithArgs = array( 'regex', 'seed', 'setversion' );
3131
3232 require_once( 'commandLine.inc' );
——@@ -125,6 +125,8 @@
126126 $this->fuzzSeed = intval( $options['seed'] ) - 1;
127127 }
128128
 129+ $this->runDisabled = isset( $options['run-disabled'] );
 130+
129131 $this->hooks = array();
130132 $this->functionHooks = array();
131133 }
——@@ -356,8 +358,8 @@
357359 if (!isset( $data['config'] ) )
358360 $data['config'] = '';
359361
360 - if (preg_match('/\\bdisabled\\b/i', $data['options'])
361 - || !preg_match("/{$this->regex}/i", $data['test'])) {
 362+ if ( (preg_match('/\\bdisabled\\b/i', $data['options'])
 363+ || !preg_match("/{$this->regex}/i", $data['test'])) && !$this->runDisabled ) {
362364 # disabled test
363365 $data = array();
364366 $section = null;
Index: trunk/phase3/maintenance/parserTests.php
——@@ -46,6 +46,7 @@
4747 --fuzz Do a fuzz test instead of a normal test
4848 --seed <n> Start the fuzz test from the specified seed
4949 --help Show this help message
 50+ --run-disabled run disabled tests
5051
5152
5253 ENDS;
Index: trunk/phase3/maintenance/parserTests.txt
——@@ -1271,6 +1271,8 @@
12721272 # specified here is now valid XML, which is an improvement . . .
12731273 !! test
12741274 Table security: embedded pipes (http://lists.wikimedia.org/mailman/htdig/wikitech-l/2006-April/022293.html)
 1275+!! options
 1276+disabled
12751277 !! input
12761278 {|
12771279 | |[ftp://|x||]" onmouseover="alert(document.cookie)">test
——@@ -1471,6 +1473,8 @@
14721474
14731475 !! test
14741476 Link containing double-single-quotes '' (bug 4598)
 1477+!! options
 1478+disabled
14751479 !! input
14761480 [[Lista d''e paise d''o munno]]
14771481 !! result
——@@ -4787,6 +4791,8 @@
47884792
47894793 !! test
47904794 HTML bullet list, unclosed tags (bug 5497)
 4795+!! options
 4796+disabled
47914797 !! input
47924798 <ul>
47934799 <li>One
——@@ -4817,6 +4823,8 @@
48184824
48194825 !! test
48204826 HTML ordered list, unclosed tags (bug 5497)
 4827+!! options
 4828+disabled
48214829 !! input
48224830 <ol>
48234831 <li>One
——@@ -4857,6 +4865,8 @@
48584866
48594867 !! test
48604868 HTML nested bullet list, open tags (bug 5497)
 4869+!! options
 4870+disabled
48614871 !! input
48624872 <ul>
48634873 <li>One
——@@ -4905,6 +4915,8 @@
49064916
49074917 !! test
49084918 HTML nested ordered list, open tags (bug 5497)
 4919+!! options
 4920+disabled
49094921 !! input
49104922 <ol>
49114923 <li>One
——@@ -5221,6 +5233,8 @@
52225234
52235235 !! test
52245236 Inline HTML vs wiki block nesting
 5237+!! options
 5238+disabled
52255239 !! input
52265240 <b>Bold paragraph
52275241
——@@ -6404,6 +6418,8 @@
64056419 # ...<dd> </dt></dl> </dd...
64066420 !! test
64076421 dt/dd/dl test
 6422+!! options
 6423+disabled
64086424 !! input
64096425 :;;;::
64106426 !! result
——@@ -6421,6 +6437,8 @@
64226438 # Images with the "|" character in external URLs in comment tags; Eats half the comment, leaves unmatched "</a>" tag.
64236439 !! test
64246440 Images with the "|" character in the comment
 6441+!! options
 6442+disabled
64256443 !! input
64266444 [[image:Foobar.jpg|thumb|An [http://test/?param1=|left|&param2=|x external] URL]]
64276445 !! result
——@@ -7093,6 +7111,8 @@
70947112 # Bug 6200: <blockquote> should behave like <div> with respect to line breaks
70957113 !! test
70967114 Bug 6200: paragraphs inside blockquotes (no extra line breaks)
 7115+!! options
 7116+disabled
70977117 !! input
70987118 <blockquote>Line one
70997119
——@@ -7105,6 +7125,8 @@
71067126
71077127 !! test
71087128 Bug 6200: paragraphs inside blockquotes (extra line break on open)
 7129+!! options
 7130+disabled
71097131 !! input
71107132 <blockquote>
71117133 Line one
——@@ -7120,6 +7142,8 @@
71217143
71227144 !! test
71237145 Bug 6200: paragraphs inside blockquotes (extra line break on close)
 7146+!! options
 7147+disabled
71247148 !! input
71257149 <blockquote>Line one
71267150
——@@ -7135,6 +7159,8 @@
71367160
71377161 !! test
71387162 Bug 6200: paragraphs inside blockquotes (extra line break on open and close)
 7163+!! options
 7164+disabled
71397165 !! input
71407166 <blockquote>
71417167 Line one
Index: trunk/phase3/CREDITS
——@@ -65,6 +65,7 @@
6666 * Carlin
6767 * Chris Wrinn
6868 * church of emacs
 69+* Dan Nessett
6970 * Daniel Arnold
7071 * Danny B.
7172 * Derk-Jan Hartman
Index: trunk/phase3/RELEASE-NOTES
——@@ -346,6 +346,8 @@
347347 * (bug 17988) Spaces before [[Category:]] links are no longer ignored
348348 * (bug 19392) Favicon, apple-touch-icon links matching the defaults are no
349349 longer sent
 350+* (bug 19957) All known-failing tests now marked disabled; added --run-disabled
 351+ option to parser test suite to run disabled tests if desired.
350352
351353 == API changes in 1.16 ==
352354

Status & tagging log