r53843 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53842‎ | r53843 | r53844 >
Date:23:53, 27 July 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 9691) Add type parameter to ModifyUITemplate function calls
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/AuthPlugin.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/AuthPlugin.php
@@ -63,8 +63,9 @@
6464 * Modify options in the login template.
6565 *
6666 * @param $template UserLoginTemplate object.
 67+ * @param $type String 'signup' or 'login'.
6768 */
68 - public function modifyUITemplate( &$template ) {
 69+ public function modifyUITemplate( &$template, &$type ) {
6970 # Override this!
7071 $template->set( 'usedomain', false );
7172 }
Index: trunk/phase3/includes/specials/SpecialUserlogin.php
@@ -931,7 +931,7 @@
932932 }
933933
934934 // Give authentication and captcha plugins a chance to modify the form
935 - $wgAuth->modifyUITemplate( $template );
 935+ $wgAuth->modifyUITemplate( $template, $this->mType );
936936 if ( $this->mType == 'signup' ) {
937937 wfRunHooks( 'UserCreateForm', array( &$template ) );
938938 } else {
Index: trunk/phase3/RELEASE-NOTES
@@ -163,6 +163,7 @@
164164 * (bug 471) Allow RSS feeds for watchlist, using an opt-in security token
165165 * (bug 10812) Interwiki links can have names and descriptions, fetched from
166166 message 'interwiki-desc-PREFIX', not really used anywhere yet though
 167+* (bug 9691) Add type (signup or login) parameter to AuthPlugin::ModifyUITemplate()
167168
168169 === Bug fixes in 1.16 ===
169170

Status & tagging log