r53688 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53687‎ | r53688 | r53689 >
Date:18:00, 23 July 2009
Author:ialex
Status:ok
Tags:
Comment:
Apply ^demon's patch. Reason was: fixes mismatched <tbody> issue from when child did not implement TablePager's getStartBody() with a trailing <tbody> Also adds <thead> around header rows, like parent does.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllmessages.php
——@@ -268,7 +268,7 @@
269269
270270 function getStartBody() {
271271 return Xml::openElement( 'table', array( 'class' => 'TablePager', 'id' => 'mw-allmessagestable' ) ) . "\n" .
272 - "<tr>
 272+ "<thead><tr>
273273 <th rowspan=\"2\">" .
274274 wfMsg( 'allmessagesname' ) . "
275275 </th>
——@@ -280,7 +280,7 @@
281281 <th>" .
282282 wfMsg( 'allmessagescurrent' ) .
283283 "</th>
284 - </tr>\n";
 284+ </tr></thead><tbody>\n";
285285 }
286286
287287 function formatValue( $field , $value ){

Status & tagging log