r53530 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53529‎ | r53530 | r53531 >
Date:05:38, 20 July 2009
Author:aaron
Status:ok (Comments)
Tags:
Comment:
(bug 19596) Fix more fucked up garbage from when $types was made into an array in various places. Log headers were missing.
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)
  • /trunk/phase3/includes/LogPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -49,12 +49,16 @@
5050
5151 /**
5252 * Set page title and show header for this log type
53 - * @param $type String
 53+ * @param $type Array
5454 */
5555 public function showHeader( $type ) {
56 - if( LogPage::isLogType( $type ) ) {
57 - $this->out->setPageTitle( LogPage::logName( $type ) );
58 - $this->out->addHTML( LogPage::logHeader( $type ) );
 56+ // If only one log type is used, then show a special message...
 57+ $headerType = (count($type) == 1) ? $type[0] : '';
 58+ if( LogPage::isLogType( $headerType ) ) {
 59+ $this->out->setPageTitle( LogPage::logName( $headerType ) );
 60+ $this->out->addHTML( LogPage::logHeader( $headerType ) );
 61+ } else {
 62+ $this->out->addHTML( wfMsgExt('alllogstext',array('parseinline')) );
5963 }
6064 }
6165
Index: trunk/phase3/includes/LogPage.php
@@ -133,6 +133,7 @@
134134
135135 /**
136136 * @static
 137+ * @param string $type logtype
137138 */
138139 public static function logName( $type ) {
139140 global $wgLogNames, $wgMessageCache;

Comments

#Comment by Aaron Schulz (talk | contribs)   05:56, 20 July 2009

Traces back to r49821

Status & tagging log