r53527 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53526‎ | r53527 | r53528 >
Date:05:14, 20 July 2009
Author:mrzman
Status:ok
Tags:
Comment:
(bug 19818) - Allow users to patrol edits to user CSS/JS subpages even if they can't edit them
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -1281,7 +1281,7 @@
12821282 # Protect css/js subpages of user pages
12831283 # XXX: this might be better using restrictions
12841284 # XXX: Find a way to work around the php bug that prevents using $this->userCanEditCssJsSubpage() from working
1285 - if( $this->isCssJsSubpage() && !$user->isAllowed('editusercssjs')
 1285+ if( $this->isCssJsSubpage() && !$user->isAllowed('editusercssjs' ) && $action != 'patrol'
12861286 && !preg_match('/^'.preg_quote($user->getName(), '/').'\//', $this->mTextform) )
12871287 {
12881288 $errors[] = array('customcssjsprotected');
Index: trunk/phase3/RELEASE-NOTES
@@ -302,6 +302,8 @@
303303 * (bug 19445) Change oldimage table to use ON UPDATE CASCADE for FK to image table.
304304 * (bug 14080) Short notation links to subpages didn't work in edit summaries
305305 * (bug 17374) Special:Export no longer exports multiple copies of pages
 306+* (bug 19818) Edits to user CSS/JS subpages can now be marked as patrolled by
 307+ users who can't edit them
306308
307309 == API changes in 1.16 ==
308310

Status & tagging log