r53509 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53508‎ | r53509 | r53510 >
Date:01:42, 20 July 2009
Author:greg
Status:deferred
Tags:
Comment:
For oldimage table, do ON UPDATE CASCADE. Per bug #19445.
Note: still needs adjustments to updaters.inc
Modified paths:
  • /trunk/phase3/maintenance/postgres/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/postgres/tables.sql
@@ -288,7 +288,7 @@
289289 oi_deleted SMALLINT NOT NULL DEFAULT 0,
290290 oi_sha1 TEXT NOT NULL DEFAULT ''
291291 );
292 -ALTER TABLE oldimage ADD CONSTRAINT oldimage_oi_name_fkey_cascade FOREIGN KEY (oi_name) REFERENCES image(img_name) ON DELETE CASCADE;
 292+ALTER TABLE oldimage ADD CONSTRAINT oldimage_oi_name_fkey_cascade FOREIGN KEY (oi_name) REFERENCES image(img_name) ON DELETE CASCADE ON UPDATE CASCADE;
293293 CREATE INDEX oi_name_timestamp ON oldimage (oi_name,oi_timestamp);
294294 CREATE INDEX oi_name_archive_name ON oldimage (oi_name,oi_archive_name);
295295 CREATE INDEX oi_sha1 ON oldimage (oi_sha1);

Follow-up revisions

RevisionCommit summaryAuthorDate
r53510Full support for modified oldimage FK constraint to do ON UPDATE CASCASE as w...greg01:54, 20 July 2009

Status & tagging log