r53495 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53494‎ | r53495 | r53496 >
Date:21:25, 19 July 2009
Author:brion
Status:ok
Tags:
Comment:
* (bug 17139) ts_resortTable inconsistent trimming makes date sorting fragile
Added a trim on the sort key preprocessing as well as the picking of the preprocessor
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -686,7 +686,7 @@
687687 if((" "+row.className+" ").indexOf(" unsortable ") < 0) {
688688 var keyText = ts_getInnerText(row.cells[column]);
689689 var oldIndex = (reverse ? -j : j);
690 - var preprocessed = preprocessor( keyText );
 690+ var preprocessed = preprocessor( keyText.replace(/^[\s\xa0]+/, "").replace(/[\s\xa0]+$/, "") );
691691
692692 newRows[newRows.length] = new Array(row, preprocessed, oldIndex);
693693 } else staticRows[staticRows.length] = new Array(row, false, j-rowStart);
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1578,7 +1578,7 @@
15791579 * to ensure that client-side caches do not keep obsolete copies of global
15801580 * styles.
15811581 */
1582 -$wgStyleVersion = '234';
 1582+$wgStyleVersion = '235';
15831583
15841584
15851585 # Server-side caching:
Index: trunk/phase3/RELEASE-NOTES
@@ -297,6 +297,7 @@
298298 * (bug 19287) Workaround for lag on history page in Firefox 3.5
299299 * (bug 19564) Updated docs/hooks.txt
300300 * (bug 18751) Fix for buggage in profiling setup for some extensions on PHP 5.1
 301+* (bug 17139) ts_resortTable inconsistent trimming makes date sorting fragile
301302
302303 == API changes in 1.16 ==
303304

Status & tagging log