r53453 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53452‎ | r53453 | r53454 >
Date:20:49, 18 July 2009
Author:minuteelectron
Status:deferred
Tags:
Comment:
Temporarily revert r52790, this extension will not work on versions of MediaWiki that use MWNamespace currently.
Modified paths:
  • /trunk/extensions/Wikidata/App.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/WikiDataAPI.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/App.php
@@ -120,7 +120,7 @@
121121
122122 function wdIsWikidataNs() {
123123 global $wgTitle;
124 - $ns=MWNamespace::get($wgTitle->getNamespace());
 124+ $ns=Namespace::get($wgTitle->getNamespace());
125125 return
126126 ($ns->getHandlerClass()=='OmegaWiki' || $ns->getHandlerClass()=='DefinedMeaning' || $ns->getHandlerClass()=='ExpressionPage');
127127
@@ -155,7 +155,7 @@
156156 function modifyTabs($skin, $content_actions) {
157157 global $wgUser, $wgTitle, $wdTesting, $wgCommunity_dc, $wdShowEditCopy;
158158 $dc=wdGetDataSetContext();
159 - $ns=MWNamespace::get($wgTitle->getNamespace());
 159+ $ns=Namespace::get($wgTitle->getNamespace());
160160 $editChanged = false;
161161 if($ns->getHandlerClass()=='DefinedMeaning') {
162162
Index: trunk/extensions/Wikidata/OmegaWiki/WikiDataAPI.php
@@ -28,7 +28,7 @@
2929 }
3030
3131 function createPage() {
32 - $expressionNameSpaceId = MWNamespace::getIndexForName('expression');
 32+ $expressionNameSpaceId = Namespace::getIndexForName('expression');
3333 wfDebug("NS ID: $expressionNameSpaceId \n");
3434 return createPage($expressionNameSpaceId, getPageTitle($this->spelling));
3535 }
@@ -768,7 +768,7 @@
769769 }
770770
771771 function addDefinedMeaning($definingExpressionId) {
772 - $definedMeaningNameSpaceId = MWNamespace::getIndexForName('definedmeaning');
 772+ $definedMeaningNameSpaceId = Namespace::getIndexForName('definedmeaning');
773773 $dc=wdGetDataSetContext();
774774
775775 $definedMeaningId = newObjectId("{$dc}_defined_meaning");

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52790fix another bunch of E_PARSEialex10:06, 6 July 2009

Status & tagging log