r53444 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53443‎ | r53444 | r53445 >
Date:14:36, 18 July 2009
Author:raymond
Status:ok
Tags:
Comment:
Follow-up r53286: More fixes for invalid HTML
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllmessages.php
@@ -66,7 +66,7 @@
6767 </tr>
6868 <tr>\n
6969 <td class='mw-label'>" .
70 - Xml::label( wfMsg( 'allmessages-filter' ), 'mw-allmessages-form-filter' ) .
 70+ Xml::label( wfMsg( 'allmessages-filter' ), 'filter' ) .
7171 "</td>\n
7272 <td class='mw-input'>" .
7373 Xml::radioLabel( wfMsg( 'allmessages-filter-unmodified' ),
@@ -267,9 +267,20 @@
268268 }
269269
270270 function getStartBody() {
271 - return "<table border=\"1\" class=\"TablePager\" style=\"width:100%;\" id=\"allmessagestable\"><thead>\n<tr>" .
272 - "<th rowspan=\"2\">" . wfMsg('allmessagesname') . "</th><th>" . wfMsg('allmessagesdefault') .
273 - "</tr>\n<tr><th>" . wfMsg('allmessagescurrent') . "</th></tr>\n";
 271+ return Xml::openElement( 'table', array( 'class' => 'TablePager', 'id' => 'mw-allmessagestable' ) ) . "\n" .
 272+ "<tr>
 273+ <th rowspan=\"2\">" .
 274+ wfMsg( 'allmessagesname' ) . "
 275+ </th>
 276+ <th>" .
 277+ wfMsg( 'allmessagesdefault' ) .
 278+ "</th>
 279+ </tr>\n
 280+ <tr>
 281+ <th>" .
 282+ wfMsg( 'allmessagescurrent' ) .
 283+ "</th>
 284+ </tr>\n";
274285 }
275286
276287 function formatValue( $field , $value ){

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53286(bug 16497) Paginate Special:AllMessagesdemon02:03, 15 July 2009

Status & tagging log