r53426 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53425‎ | r53426 | r53427 >
Date:22:31, 17 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Reduced superfluous (and bug causing) specificity in most ID based rules.
Modified paths:
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -28,7 +28,7 @@
2929 background-image: url(images/page-base.png);
3030 }
3131 /* Content */
32 -div#content {
 32+#content {
3333 margin-left: 12em;
3434 padding: 1em;
3535 background-image: url(images/border.png);
——@@ -37,14 +37,14 @@
3838 background-color: white;
3939 }
4040 /* Head */
41 -div#page-base {
 41+#page-base {
4242 height: 6em;
4343 background-color: white;
4444 background-image: url(images/page-fade.png);
4545 background-position: bottom left;
4646 background-repeat: repeat-x;
4747 }
48 -div#head-base {
 48+#head-base {
4949 margin-top: -6em;
5050 margin-left: 12em;
5151 height: 6em;
——@@ -52,46 +52,46 @@
5353 background-position: bottom left;
5454 background-repeat: repeat-x;
5555 }
56 -div#head {
 56+#head {
5757 position: absolute;
5858 top: 0;
5959 right: 0;
6060 width: 100%;
6161 }
62 -div#head h5 {
 62+#head h5 {
6363 margin: 0;
6464 padding: 0;
6565 }
6666 /* Personal */
67 - div#p-personal {
 67+ #p-personal {
6868 position: absolute;
6969 top: 0;
7070 right: 0.75em;
7171 }
72 - div#p-personal h5 {
 72+ #p-personal h5 {
7373 display: none;
7474 }
75 - div#p-personal ul {
 75+ #p-personal ul {
7676 list-style: none;
7777 margin: 0;
7878 padding: 0;
7979 }
8080 /* @noflip */
81 - div#p-personal li {
 81+ #p-personal li {
8282 float: left;
8383 }
84 - div#p-personal li {
 84+ #p-personal li {
8585 margin-left: 0.75em;
8686 margin-top: 0.5em;
8787 font-size: 0.9em;
8888 }
8989 /* Navigation Containers */
90 - div#left-navigation {
 90+ #left-navigation {
9191 position: absolute;
9292 left: 12em;
9393 top: 3em;
9494 }
95 - div#right-navigation {
 95+ #right-navigation {
9696 float: right;
9797 margin-top: 3em;
9898 }
——@@ -275,23 +275,23 @@
276276 display: block;
277277 }
278278 /* Search */
279 - div#p-search h5 {
 279+ #p-search h5 {
280280 display: none;
281281 }
282282 /* @noflip */
283 - div#p-search {
 283+ #p-search {
284284 float: left;
285285 }
286 - div#p-search {
 286+ #p-search {
287287 margin-right: 0.5em;
288288 margin-left: 0.5em;
289289 }
290 - div#p-search form,
291 - div#p-search input {
 290+ #p-search form,
 291+ #p-search input {
292292 margin: 0;
293293 margin-top: 0.4em;
294294 }
295 - div#p-search div#simpleSearch {
 295+ #simpleSearch {
296296 margin-top: 0.75em;
297297 position: relative;
298298 border: solid 1px #AAAAAA;
——@@ -300,7 +300,7 @@
301301 background-position: top left;
302302 background-repeat: repeat-x;
303303 }
304 - div#p-search div#simpleSearch input#searchInput {
 304+ #simpleSearch input#searchInput {
305305 margin: 0;
306306 border-width: 0;
307307 padding: 0.25em;
——@@ -310,7 +310,7 @@
311311 background-color: transparent;
312312 }
313313 /* OVERRIDDEN BY COMPLIANT BROWSERS */
314 - div#p-search div#simpleSearch button#searchButton {
 314+ #simpleSearch button#searchButton {
315315 position: absolute;
316316 top: 0;
317317 right: 0;
——@@ -326,20 +326,20 @@
327327 background-repeat: no-repeat;
328328 }
329329 /* IGNORED BY IE6 */
330 - div#p-search div#simpleSearch > button#searchButton {
 330+ #simpleSearch > button#searchButton {
331331 height: 100%;
332332 }
333333 /* Panel */
334 -div#panel {
 334+#panel {
335335 position: absolute;
336336 top: 12em;
337337 width: 12em;
338338 left: 0;
339339 }
340 - div#panel div.portal {
 340+ #panel div.portal {
341341 padding-top: 1.5em;
342342 }
343 - div#panel div.portal h5 {
 343+ #panel div.portal h5 {
344344 font-weight: normal;
345345 color: #444444;
346346 padding: 0.5em;
——@@ -349,7 +349,7 @@
350350 border: none;
351351 font-size: 0.9em;
352352 }
353 - div#panel div.portal div.body {
 353+ #panel div.portal div.body {
354354 margin: 0;
355355 padding-top: 0.5em;
356356 margin-left: 1.25em;
——@@ -357,26 +357,26 @@
358358 background-repeat: no-repeat;
359359 background-position: top left;
360360 }
361 - div#panel div.portal div.body ul {
 361+ #panel div.portal div.body ul {
362362 list-style: none;
363363 padding: 0;
364364 margin: 0;
365365 }
366 - div#panel div.portal div.body ul li {
 366+ #panel div.portal div.body ul li {
367367 padding: 0;
368368 padding-bottom: 0.5em;
369369 margin: 0;
370370 overflow: hidden;
371371 font-size: 0.9em;
372372 }
373 - div#panel div.portal div.body ul li a {
 373+ #panel div.portal div.body ul li a {
374374 color: #0645ad;
375375 }
376 - div#panel div.portal div.body ul li a:visited {
 376+ #panel div.portal div.body ul li a:visited {
377377 color: #0b0080;
378378 }
379379 /* Foot */
380 -div#foot {
 380+#foot {
381381 margin-left: 12em;
382382 margin-top: 0;
383383 padding: 0.75em;
——@@ -384,12 +384,12 @@
385385 background-position: top left;
386386 background-repeat: repeat-x;
387387 }
388 -div#foot ul {
 388+#foot ul {
389389 list-style: none;
390390 margin: 0;
391391 padding: 0;
392392 }
393 -div#foot ul li {
 393+#foot ul li {
394394 margin: 0;
395395 padding: 0;
396396 padding-top: 0.5em;
——@@ -397,21 +397,21 @@
398398 color: #333333;
399399 font-size: 0.9em;
400400 }
401 -div#foot ul#foot-icons {
 401+#foot #foot-icons {
402402 float: right;
403403 }
404 -div#foot ul#foot-places {
 404+#foot #foot-places {
405405 float: left;
406406 }
407 -div#foot ul#foot-info li {
 407+#foot #foot-info li {
408408 line-height: 1.4em;
409409 }
410 -div#foot ul#foot-icons li {
 410+#foot #foot-icons li {
411411 float: left;
412412 margin-left: 0.5em;
413413 line-height: 2em;
414414 }
415 -div#foot ul#foot-places li {
 415+#foot #foot-places li {
416416 float: left;
417417 margin-right: 1em;
418418 line-height: 2em;
——@@ -646,31 +646,31 @@
647647 background-color: #f9f9f9;
648648 line-height: 1.1em;
649649 }
650 -div#content ul {
 650+#content ul {
651651 line-height: 1.5em;
652652 list-style-type: square;
653653 margin: .3em 0 0 1.5em;
654654 padding: 0;
655655 list-style-image: url(images/bullet-icon.png);
656656 }
657 -div#content ol {
 657+#content ol {
658658 line-height: 1.5em;
659659 margin: .3em 0 0 3.2em;
660660 padding: 0;
661661 list-style-image: none;
662662 }
663 -div#content li {
 663+#content li {
664664 margin-bottom: .1em;
665665 }
666 -div#content dt {
 666+#content dt {
667667 font-weight: bold;
668668 margin-bottom: .1em;
669669 }
670 -div#content dl {
 670+#content dl {
671671 margin-top: .2em;
672672 margin-bottom: .5em;
673673 }
674 -div#content dd {
 674+#content dd {
675675 line-height: 1.5em;
676676 margin-left: 2em;
677677 margin-bottom: .1em;
——@@ -683,12 +683,12 @@
684684 * floated tables */
685685 background-color: white;
686686 }
687 -div#content fieldset table {
 687+#content fieldset table {
688688 /* but keep table layouts in forms clean... */
689689 background: none;
690690 }
691691 /* Forms */
692 -div#content fieldset {
 692+#content fieldset {
693693 border: 1px solid #2f6fab;
694694 margin: 1em 0 1em 0;
695695 padding: 0 1em 1em;
——@@ -698,19 +698,19 @@
699699 margin: 0 0 0.5em 0;
700700 padding: 0 0.5em 0.5em;
701701 }
702 -div#content legend {
 702+#content legend {
703703 padding: .5em;
704704 font-size: 95%;
705705 }
706 -div#content form {
 706+#content form {
707707 border: none;
708708 margin: 0;
709709 }
710 -div#content textarea {
 710+#content textarea {
711711 width: 100%;
712712 padding: .1em;
713713 }
714 -div#content select {
 714+#content select {
715715 vertical-align: top;
716716 }
717717 /* Table of Contents */
——@@ -736,8 +736,8 @@
737737 .toc .toctitle {
738738 text-align: center;
739739 }
740 -div#content #toc ul,
741 -div#content .toc ul {
 740+#toc ul,
 741+.toc ul {
742742 list-style-type: none;
743743 list-style-image: none;
744744 margin-left: 0;
——@@ -895,7 +895,7 @@
896896 #content h3, #content h4, #content h5 {
897897 margin-bottom: .3em;
898898 }
899 -h1#firstHeading {
 899+#firstHeading {
900900 padding-top: 0;
901901 margin-top: 0;
902902 padding-top: 0;
——@@ -971,29 +971,25 @@
972972 #content .printfooter {
973973 display: none;
974974 }
975 -
976 -
977 -li#pt-userpage,
978 -li#pt-anonuserpage,
979 -li#pt-login {
 975+/* Icon for Usernames */
 976+#pt-userpage,
 977+#pt-anonuserpage,
 978+#pt-login {
980979 background: url(images/user-icon.png) left top no-repeat;
981980 padding-left: 15px !important;
982981 text-transform: none;
983982 }
984 -
 983+/* To be sorted */
985984 span.newpage, span.minor, span.bot {
986985 font-weight: bold;
987986 }
988 -
989987 .toccolours {
990988 border: 1px solid #aaa;
991989 background-color: #f9f9f9;
992990 padding: 5px;
993991 font-size: 95%;
994992 }
995 -
996 -div#bodyContent {
 993+#bodyContent {
997994 position: relative;
998995 width: 100%;
999 -}
1000 -
 996+}
\ No newline at end of file
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -28,7 +28,7 @@
2929 background-image: url(images/page-base.png);
3030 }
3131 /* Content */
32 -div#content {
 32+#content {
3333 margin-right: 12em;
3434 padding: 1em;
3535 background-image: url(images/border.png);
——@@ -37,14 +37,14 @@
3838 background-color: white;
3939 }
4040 /* Head */
41 -div#page-base {
 41+#page-base {
4242 height: 6em;
4343 background-color: white;
4444 background-image: url(images/page-fade.png);
4545 background-position: bottom right;
4646 background-repeat: repeat-x;
4747 }
48 -div#head-base {
 48+#head-base {
4949 margin-top: -6em;
5050 margin-right: 12em;
5151 height: 6em;
——@@ -52,46 +52,46 @@
5353 background-position: bottom right;
5454 background-repeat: repeat-x;
5555 }
56 -div#head {
 56+#head {
5757 position: absolute;
5858 top: 0;
5959 left: 0;
6060 width: 100%;
6161 }
62 -div#head h5 {
 62+#head h5 {
6363 margin: 0;
6464 padding: 0;
6565 }
6666 /* Personal */
67 - div#p-personal {
 67+ #p-personal {
6868 position: absolute;
6969 top: 0;
7070 left: 0.75em;
7171 }
72 - div#p-personal h5 {
 72+ #p-personal h5 {
7373 display: none;
7474 }
75 - div#p-personal ul {
 75+ #p-personal ul {
7676 list-style: none;
7777 margin: 0;
7878 padding: 0;
7979 }
8080 /* @noflip */
81 - div#p-personal li {
 81+ #p-personal li {
8282 float: left;
8383 }
84 - div#p-personal li {
 84+ #p-personal li {
8585 margin-right: 0.75em;
8686 margin-top: 0.5em;
8787 font-size: 0.9em;
8888 }
8989 /* Navigation Containers */
90 - div#left-navigation {
 90+ #left-navigation {
9191 position: absolute;
9292 right: 12em;
9393 top: 3em;
9494 }
95 - div#right-navigation {
 95+ #right-navigation {
9696 float: left;
9797 margin-top: 3em;
9898 }
——@@ -275,23 +275,23 @@
276276 display: block;
277277 }
278278 /* Search */
279 - div#p-search h5 {
 279+ #p-search h5 {
280280 display: none;
281281 }
282282 /* @noflip */
283 - div#p-search {
 283+ #p-search {
284284 float: left;
285285 }
286 - div#p-search {
 286+ #p-search {
287287 margin-left: 0.5em;
288288 margin-right: 0.5em;
289289 }
290 - div#p-search form,
291 - div#p-search input {
 290+ #p-search form,
 291+ #p-search input {
292292 margin: 0;
293293 margin-top: 0.4em;
294294 }
295 - div#p-search div#simpleSearch {
 295+ #simpleSearch {
296296 margin-top: 0.75em;
297297 position: relative;
298298 border: solid 1px #AAAAAA;
——@@ -300,7 +300,7 @@
301301 background-position: top right;
302302 background-repeat: repeat-x;
303303 }
304 - div#p-search div#simpleSearch input#searchInput {
 304+ #simpleSearch input#searchInput {
305305 margin: 0;
306306 border-width: 0;
307307 padding: 0.25em;
——@@ -310,7 +310,7 @@
311311 background-color: transparent;
312312 }
313313 /* OVERRIDDEN BY COMPLIANT BROWSERS */
314 - div#p-search div#simpleSearch button#searchButton {
 314+ #simpleSearch button#searchButton {
315315 position: absolute;
316316 top: 0;
317317 left: 0;
——@@ -326,20 +326,20 @@
327327 background-repeat: no-repeat;
328328 }
329329 /* IGNORED BY IE6 */
330 - div#p-search div#simpleSearch > button#searchButton {
 330+ #simpleSearch > button#searchButton {
331331 height: 100%;
332332 }
333333 /* Panel */
334 -div#panel {
 334+#panel {
335335 position: absolute;
336336 top: 12em;
337337 width: 12em;
338338 right: 0;
339339 }
340 - div#panel div.portal {
 340+ #panel div.portal {
341341 padding-top: 1.5em;
342342 }
343 - div#panel div.portal h5 {
 343+ #panel div.portal h5 {
344344 font-weight: normal;
345345 color: #444444;
346346 padding: 0.5em;
——@@ -349,7 +349,7 @@
350350 border: none;
351351 font-size: 0.9em;
352352 }
353 - div#panel div.portal div.body {
 353+ #panel div.portal div.body {
354354 margin: 0;
355355 padding-top: 0.5em;
356356 margin-right: 1.25em;
——@@ -357,26 +357,26 @@
358358 background-repeat: no-repeat;
359359 background-position: top right;
360360 }
361 - div#panel div.portal div.body ul {
 361+ #panel div.portal div.body ul {
362362 list-style: none;
363363 padding: 0;
364364 margin: 0;
365365 }
366 - div#panel div.portal div.body ul li {
 366+ #panel div.portal div.body ul li {
367367 padding: 0;
368368 padding-bottom: 0.5em;
369369 margin: 0;
370370 overflow: hidden;
371371 font-size: 0.9em;
372372 }
373 - div#panel div.portal div.body ul li a {
 373+ #panel div.portal div.body ul li a {
374374 color: #0645ad;
375375 }
376 - div#panel div.portal div.body ul li a:visited {
 376+ #panel div.portal div.body ul li a:visited {
377377 color: #0b0080;
378378 }
379379 /* Foot */
380 -div#foot {
 380+#foot {
381381 margin-right: 12em;
382382 margin-top: 0;
383383 padding: 0.75em;
——@@ -384,12 +384,12 @@
385385 background-position: top right;
386386 background-repeat: repeat-x;
387387 }
388 -div#foot ul {
 388+#foot ul {
389389 list-style: none;
390390 margin: 0;
391391 padding: 0;
392392 }
393 -div#foot ul li {
 393+#foot ul li {
394394 margin: 0;
395395 padding: 0;
396396 padding-top: 0.5em;
——@@ -397,21 +397,21 @@
398398 color: #333333;
399399 font-size: 0.9em;
400400 }
401 -div#foot ul#foot-icons {
 401+#foot #foot-icons {
402402 float: left;
403403 }
404 -div#foot ul#foot-places {
 404+#foot #foot-places {
405405 float: right;
406406 }
407 -div#foot ul#foot-info li {
 407+#foot #foot-info li {
408408 line-height: 1.4em;
409409 }
410 -div#foot ul#foot-icons li {
 410+#foot #foot-icons li {
411411 float: right;
412412 margin-right: 0.5em;
413413 line-height: 2em;
414414 }
415 -div#foot ul#foot-places li {
 415+#foot #foot-places li {
416416 float: right;
417417 margin-left: 1em;
418418 line-height: 2em;
——@@ -646,31 +646,31 @@
647647 background-color: #f9f9f9;
648648 line-height: 1.1em;
649649 }
650 -div#content ul {
 650+#content ul {
651651 line-height: 1.5em;
652652 list-style-type: square;
653653 margin: .3em 1.5em 0 0;
654654 padding: 0;
655655 list-style-image: url(images/bullet-icon.png);
656656 }
657 -div#content ol {
 657+#content ol {
658658 line-height: 1.5em;
659659 margin: .3em 3.2em 0 0;
660660 padding: 0;
661661 list-style-image: none;
662662 }
663 -div#content li {
 663+#content li {
664664 margin-bottom: .1em;
665665 }
666 -div#content dt {
 666+#content dt {
667667 font-weight: bold;
668668 margin-bottom: .1em;
669669 }
670 -div#content dl {
 670+#content dl {
671671 margin-top: .2em;
672672 margin-bottom: .5em;
673673 }
674 -div#content dd {
 674+#content dd {
675675 line-height: 1.5em;
676676 margin-right: 2em;
677677 margin-bottom: .1em;
——@@ -683,12 +683,12 @@
684684 * floated tables */
685685 background-color: white;
686686 }
687 -div#content fieldset table {
 687+#content fieldset table {
688688 /* but keep table layouts in forms clean... */
689689 background: none;
690690 }
691691 /* Forms */
692 -div#content fieldset {
 692+#content fieldset {
693693 border: 1px solid #2f6fab;
694694 margin: 1em 0 1em 0;
695695 padding: 0 1em 1em;
——@@ -698,19 +698,19 @@
699699 margin: 0 0 0.5em 0;
700700 padding: 0 0.5em 0.5em;
701701 }
702 -div#content legend {
 702+#content legend {
703703 padding: .5em;
704704 font-size: 95%;
705705 }
706 -div#content form {
 706+#content form {
707707 border: none;
708708 margin: 0;
709709 }
710 -div#content textarea {
 710+#content textarea {
711711 width: 100%;
712712 padding: .1em;
713713 }
714 -div#content select {
 714+#content select {
715715 vertical-align: top;
716716 }
717717 /* Table of Contents */
——@@ -736,8 +736,8 @@
737737 .toc .toctitle {
738738 text-align: center;
739739 }
740 -div#content #toc ul,
741 -div#content .toc ul {
 740+#toc ul,
 741+.toc ul {
742742 list-style-type: none;
743743 list-style-image: none;
744744 margin-right: 0;
——@@ -895,7 +895,7 @@
896896 #content h3, #content h4, #content h5 {
897897 margin-bottom: .3em;
898898 }
899 -h1#firstHeading {
 899+#firstHeading {
900900 padding-top: 0;
901901 margin-top: 0;
902902 padding-top: 0;
——@@ -971,29 +971,25 @@
972972 #content .printfooter {
973973 display: none;
974974 }
975 -
976 -
977 -li#pt-userpage,
978 -li#pt-anonuserpage,
979 -li#pt-login {
 975+/* Icon for Usernames */
 976+#pt-userpage,
 977+#pt-anonuserpage,
 978+#pt-login {
980979 background: url(images/user-icon.png) right top no-repeat;
981980 padding-right: 15px !important;
982981 text-transform: none;
983982 }
984 -
 983+/* To be sorted */
985984 span.newpage, span.minor, span.bot {
986985 font-weight: bold;
987986 }
988 -
989987 .toccolours {
990988 border: 1px solid #aaa;
991989 background-color: #f9f9f9;
992990 padding: 5px;
993991 font-size: 95%;
994992 }
995 -
996 -div#bodyContent {
 993+#bodyContent {
997994 position: relative;
998995 width: 100%;
999 -}
1000 -
 996+}
\ No newline at end of file

Status & tagging log