r53396 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53395‎ | r53396 | r53397 >
Date:14:03, 17 July 2009
Author:werdna
Status:deferred
Tags:
Comment:
Fix weird bug where unchanged conditions were being parsed as wikitext in diff displays, and usage of deprecated method
Modified paths:
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewDiff.php (modified) (history)
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewHistory.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewDiff.php
@@ -316,13 +316,9 @@
317317 if ( $old == $new ) {
318318 $old = implode( "<br/>\n", $old );
319319 $new = implode( "<br/>\n", $new );
320 - return $this->getSimpleRow( $msg, $old, $new );
 320+ return $this->getSimpleRow( $msg, $old, $new, 'text' );
321321 }
322322
323 - // Hacky fix for double-escaping.
324 - $old = array_map( 'html_entity_decode', $old );
325 - $new = array_map( 'html_entity_decode', $new );
326 -
327323 $row = '';
328324 $row .= Xml::tags( 'th', null, wfMsgExt( $msg, 'parseinline' ) );
329325
Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewHistory.php
@@ -56,7 +56,7 @@
5757 }
5858
5959 // Add filtering of changes et al.
60 - $fields['abusefilter-history-select-user'] = wfInput( 'user', 45, $user );
 60+ $fields['abusefilter-history-select-user'] = Xml::input( 'user', 45, $user );
6161
6262 $filterForm = Xml::buildForm( $fields, 'abusefilter-history-select-submit' );
6363 $filterForm .= "\n" . Xml::hidden( 'title', $this->getTitle( "history/$filter" ) );

Status & tagging log