r53384 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53383‎ | r53384 | r53385 >
Date:22:55, 16 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Prevent wrapping by using   instead of spaces in labels on drop down menus. Not ideal, but for cross browser support down to IE5.5, this is what we end up with.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -718,7 +718,7 @@
719719 <div class="menu">
720720 <ul <?php $this->html('userlangattributes') ?>>
721721 <?php foreach ($this->data['variant_urls'] as $key => $link ): ?>
722 - <li<?php echo $link['attributes'] ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo htmlspecialchars( $link['text'] ) ?></a></li>
 722+ <li<?php echo $link['attributes'] ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo str_replace( ' ', '&nbsp;', htmlspecialchars( $link['text'] ) ) ?></a></li>
723723 <?php endforeach; ?>
724724 </ul>
725725 </div>
@@ -748,7 +748,7 @@
749749 <div class="menu">
750750 <ul <?php $this->html('userlangattributes') ?>>
751751 <?php foreach ($this->data['action_urls'] as $key => $link ): ?>
752 - <li<?php echo $link['attributes'] ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo htmlspecialchars( $link['text'] ) ?></a></li>
 752+ <li<?php echo $link['attributes'] ?>><a href="<?php echo htmlspecialchars( $link['href'] ) ?>" <?php echo $link['key'] ?>><?php echo str_replace( ' ', '&nbsp;', htmlspecialchars( $link['text'] ) ) ?></a></li>
753753 <?php endforeach; ?>
754754 </ul>
755755 </div>

Status & tagging log