r5338 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r5337‎ | r5338 | r5339 >
Date:00:17, 21 September 2004
Author:timwi
Status:old
Tags:
Comment:
bugfix: Special:Allpages "next" link should include &namespace= parameter
Modified paths:
  • /trunk/phase3/includes/SpecialAllpages.php (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialAllpages.php
@@ -51,7 +51,8 @@
5252
5353 $out = "<div class='namespaceselector'><form method='get' action='{$wgScript}'>";
5454 $out .= '<input type="hidden" name="title" value="'.$t->getPrefixedText().'" />';
55 - $out .= wfMsg ( 'allpagesformtext', $frombox, $namespaceselect, $submitbutton );
 55+ $out .= wfMsg ( 'allpagesformtext1', $frombox ) . '<br />';
 56+ $out .= wfMsg ( 'allpagesformtext2', $namespaceselect, $submitbutton );
5657 $out .= '</form></div>';
5758 return $out;
5859 }
@@ -226,10 +227,11 @@
227228 $sk->makeKnownLink( $wgLang->specialPage( "Allpages" ),
228229 wfMsg ( 'allpages' ) );
229230 if ( ($n == $indexMaxperpage) && ($s = $dbr->fetchObject( $res )) ) {
 231+ $namespaceparam = $namespace ? "&namespace=$namespace" : "";
230232 $out2 .= " | " . $sk->makeKnownLink(
231233 $wgLang->specialPage( "Allpages" ),
232234 wfMsg ( 'nextpage', $s->cur_title ),
233 - "from=" . wfUrlEncode ( $s->cur_title ) );
 235+ "from=" . wfUrlEncode ( $s->cur_title ) . $namespaceparam );
234236 }
235237 $out2 .= "</td></tr></table><hr />";
236238
Index: trunk/phase3/languages/Language.php
@@ -1029,7 +1029,8 @@
10301030 # Special:Allpages
10311031 'nextpage' => 'Next page ($1)',
10321032 'articlenamespace' => '(articles)',
1033 -'allpagesformtext' => 'Display pages starting at: $1 Choose namespace: $2 $3',
 1033+'allpagesformtext1' => 'Display pages starting at: $1',
 1034+'allpagesformtext2' => 'Choose namespace: $2 $3',
10341035 'allarticles' => 'All articles',
10351036 'allpagesprev' => 'Previous',
10361037 'allpagesnext' => 'Next',

Status & tagging log