r53361 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53360‎ | r53361 | r53362 >
Date:15:28, 16 July 2009
Author:dale
Status:resolved (Comments)
Tags:
Comment:
fixed unset partname
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
——@@ -405,6 +405,8 @@
406406
407407 $filenamePrefixBlacklist = UploadBase::getFilenamePrefixBlacklist();
408408 # Do the match
 409+ if(!isset($partname))
 410+ $partname = '';
409411 foreach( $filenamePrefixBlacklist as $prefix ) {
410412 if ( substr( $partname, 0, strlen( $prefix ) ) == $prefix ) {
411413 $warning .= '<li>' . wfMsgExt( 'filename-bad-prefix', 'parseinline', $prefix ) . '</li>';

Comments

#Comment by Brion VIBBER (talk | contribs)   00:49, 22 August 2009

Something ain't right presently; $partname isn't initialized *anywhere* in this function, but there are comparisons against it both above and below this line.

#Comment by Mdale (talk | contribs)   05:25, 22 August 2009

hmmm it must have been clobbered in the merge (?) re-added in r55464

Status & tagging log