r53353 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53352‎ | r53353 | r53354 >
Date:08:04, 16 July 2009
Author:catrope
Status:ok
Tags:
Comment:
Revert r52190 ("Return HTTP 503 on API maxlag error"): announcement prompted many complaints, and the change never went live.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiMain.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiMain.php
@@ -378,9 +378,9 @@
379379 header( 'Retry-After: ' . max( intval( $maxLag ), 5 ) );
380380 header( 'X-Database-Lag: ' . intval( $lag ) );
381381 if( $wgShowHostnames ) {
382 - $this->dieUsage( "Waiting for $host: $lag seconds lagged", 'maxlag', 503 );
 382+ $this->dieUsage( "Waiting for $host: $lag seconds lagged", 'maxlag' );
383383 } else {
384 - $this->dieUsage( "Waiting for a database server: $lag seconds lagged", 'maxlag', 503 );
 384+ $this->dieUsage( "Waiting for a database server: $lag seconds lagged", 'maxlag' );
385385 }
386386 return;
387387 }
Index: trunk/phase3/RELEASE-NOTES
@@ -306,7 +306,6 @@
307307 * (bug 18785) Add siprop=languages to meta=siteinfo
308308 * (bug 14200) Added user and excludeuser parameters to list=watchlist and
309309 list=recentchanges
310 -* Return HTTP 503 status code on maxlag error, like index.php does
311310 * Added index, fromtitle and byteoffset fields to action=parse&prop=sections
312311 output
313312 * (bug 19313) action=rollback returns wrong revid on master/slave setups

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52190API: Return HTTP 503 status code on maxlag error, like index.php doescatrope08:10, 20 June 2009

Status & tagging log