r53339 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53338‎ | r53339 | r53340 >
Date:22:51, 15 July 2009
Author:demon
Status:ok
Tags:
Comment:
(bug 18821) Delete unused fetchAllRevisions(), which doesn't do what it says anyway.
Modified paths:
  • /trunk/phase3/includes/Revision.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Revision.php
@@ -226,24 +226,6 @@
227227 * @access public
228228 * @static
229229 */
230 - public static function fetchAllRevisions( $title ) {
231 - return Revision::fetchFromConds(
232 - wfGetDB( DB_SLAVE ),
233 - array( 'page_namespace' => $title->getNamespace(),
234 - 'page_title' => $title->getDBkey(),
235 - 'page_id=rev_page' ) );
236 - }
237 -
238 - /**
239 - * Return a wrapper for a series of database rows to
240 - * fetch all of a given page's revisions in turn.
241 - * Each row can be fed to the constructor to get objects.
242 - *
243 - * @param Title $title
244 - * @return ResultWrapper
245 - * @access public
246 - * @static
247 - */
248230 public static function fetchRevision( $title ) {
249231 return Revision::fetchFromConds(
250232 wfGetDB( DB_SLAVE ),

Status & tagging log