r53293 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53292‎ | r53293 | r53294 >
Date:06:43, 15 July 2009
Author:nikerabbit
Status:resolved
Tags:
Comment:
Couple of issues in r53270: use accessor method and keep the function signature bc
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -1639,7 +1639,7 @@
16401640 * @param Title $title Title to link
16411641 * @param string $query Query string
16421642 */
1643 - public function addReturnTo( $title, $query ) {
 1643+ public function addReturnTo( $title, $query = array() ) {
16441644 global $wgUser;
16451645 $this->addLink( array( 'rel' => 'next', 'href' => $title->getFullUrl() ) );
16461646 $link = wfMsgHtml( 'returnto', $wgUser->getSkin()->link(
Index: trunk/phase3/includes/SkinTemplate.php
@@ -176,7 +176,7 @@
177177 wfProfileIn( __METHOD__ . '-stuff' );
178178 $this->thispage = $this->mTitle->getPrefixedDBkey();
179179 $this->thisurl = $this->mTitle->getPrefixedURL();
180 - $query = $wgRequest->data;
 180+ $query = $wgRequest->getValues();
181181 unset( $query['title'] );
182182 $this->thisquery = wfArrayToCGI( $query );
183183 $this->loggedin = $wgUser->isLoggedIn();

Follow-up revisions

RevisionCommit summaryAuthorDate
r54535Merge trunk fixes to support returnto query params, needed for OptIn smoothness...brion18:15, 6 August 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53270Add returntoquery= parameter to Special:Userlogin which adds a query string t...catrope21:25, 14 July 2009

Status & tagging log