r53247 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53246‎ | r53247 | r53248 >
Date:17:39, 14 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
More RTL fixes and also another fix to r52944 which broke the inclusion of common/IEFixes.js
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -42,6 +42,17 @@
4343 $wgStylePath .
4444 '/vector/csshover.htc")}</style><![endif]-->'
4545 );
 46+ // Append common IE fixes, which perhaps should be included in all
 47+ // skins, but for now it seems each skin needs to include them
 48+ // explicitly
 49+ $out->addScript(
 50+ '<!--[if lt IE 7]><script type="' . $wgJsMimeType . '" src="' .
 51+ $wgStylePath .
 52+ '/common/IEFixes.js?' .
 53+ $wgStyleVersion .
 54+ '"></script>' .
 55+ '<meta http-equiv="imagetoolbar" content="no" /><![endif]-->'
 56+ );
4657 }
4758 /**
4859 * Builds a structured array of links used for tabs and menus
Index: trunk/phase3/skins/vector/main-ltr.css
@@ -21,7 +21,7 @@
2222 margin: 0;
2323 padding: 0;
2424 font-family: sans-serif;
25 - font-size: small;
 25+ font-size: 9.75pt;
2626 }
2727 body {
2828 background-color: #f3f3f3;
@@ -190,14 +190,15 @@
191191 /* Variants and Actions */
192192 /* @noflip */
193193 div.vectorMenu {
 194+ direction: ltr;
194195 float: left;
195 - direction: ltr;
196 - }
197 - div.vectorMenu {
198196 background-image: url(images/arrow-down-icon.png);
199197 background-position: center center;
200198 background-repeat: no-repeat;
201199 }
 200+ body.rtl div.vectorMenu {
 201+ direction: rtl;
 202+ }
202203 /* @noflip */
203204 div.vectorMenu h5 {
204205 float: left;
@@ -220,7 +221,21 @@
221222 position: relative;
222223 display: none;
223224 clear: both;
 225+ text-align: left;
224226 }
 227+ /* OVERRIDDEN BY COMPLIANT BROWSERS */
 228+ body.rtl div.vectorMenu div.menu {
 229+ margin-right: 24px;
 230+ }
 231+ /* IGNORED BY IE6 */
 232+ body.rtl div.vectorMenu > div.menu {
 233+ margin-right: auto;
 234+ }
 235+ /* Fixes old versions of FireFox */
 236+ body.rtl div.vectorMenu > div.menu,
 237+ x:-moz-any-link {
 238+ margin-right: 24px;
 239+ }
225240 div.vectorMenu:hover div.menu {
226241 display: block;
227242 }
@@ -233,7 +248,13 @@
234249 padding: 0;
235250 margin: 0;
236251 margin-left: -1px;
 252+ text-align: left;
237253 }
 254+ /* Fixes old versions of FireFox */
 255+ div.vectorMenu ul,
 256+ x:-moz-any-link {
 257+ min-width: 6em;
 258+ }
238259 div.vectorMenu li {
239260 padding: 0;
240261 margin: 0;
Index: trunk/phase3/skins/vector/main-rtl.css
@@ -21,7 +21,7 @@
2222 margin: 0;
2323 padding: 0;
2424 font-family: sans-serif;
25 - font-size: small;
 25+ font-size: 9.75pt;
2626 }
2727 body {
2828 background-color: #f3f3f3;
@@ -190,14 +190,15 @@
191191 /* Variants and Actions */
192192 /* @noflip */
193193 div.vectorMenu {
 194+ direction: ltr;
194195 float: left;
195 - direction: ltr;
196 - }
197 - div.vectorMenu {
198196 background-image: url(images/arrow-down-icon.png);
199197 background-position: center center;
200198 background-repeat: no-repeat;
201199 }
 200+ body.rtl div.vectorMenu {
 201+ direction: rtl;
 202+ }
202203 /* @noflip */
203204 div.vectorMenu h5 {
204205 float: left;
@@ -220,7 +221,21 @@
221222 position: relative;
222223 display: none;
223224 clear: both;
 225+ text-align: right;
224226 }
 227+ /* OVERRIDDEN BY COMPLIANT BROWSERS */
 228+ body.rtl div.vectorMenu div.menu {
 229+ margin-left: 24px;
 230+ }
 231+ /* IGNORED BY IE6 */
 232+ body.rtl div.vectorMenu > div.menu {
 233+ margin-left: auto;
 234+ }
 235+ /* Fixes old versions of FireFox */
 236+ body.rtl div.vectorMenu > div.menu,
 237+ x:-moz-any-link {
 238+ margin-left: 24px;
 239+ }
225240 div.vectorMenu:hover div.menu {
226241 display: block;
227242 }
@@ -233,7 +248,13 @@
234249 padding: 0;
235250 margin: 0;
236251 margin-right: -1px;
 252+ text-align: right;
237253 }
 254+ /* Fixes old versions of FireFox */
 255+ div.vectorMenu ul,
 256+ x:-moz-any-link {
 257+ min-width: 6em;
 258+ }
238259 div.vectorMenu li {
239260 padding: 0;
240261 margin: 0;

Follow-up revisions

RevisionCommit summaryAuthorDate
r53410Merging UI fixes from trunk; second batch from http://www.mediawiki.org/wiki/......brion18:05, 17 July 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52944Moved buildNavigationUrls into SkinTemplate from SkinVector which inherits Sk...tparscal20:59, 8 July 2009

Status & tagging log