r53199 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r53198‎ | r53199 | r53200 >
Date:22:18, 13 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Resolved some link coloring issues in the navigation tabs. Regenerated the RTL stylesheet using cssjanus. Made comments more logical for this type of operation.
Modified paths:
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -1,3 +1,16 @@
 2+/*
 3+ * main-rtl.css is automatically generated using CSSJanus, a python script for
 4+ * creating RTL versions of otherwise LTR stylesheets.
 5+ *
 6+ * You may download the tool to rebuild this stylesheet
 7+ * http://code.google.com/p/cssjanus/
 8+ *
 9+ * An online version of this tool can be used at:
 10+ * http://cssjanus.commoner.com/
 11+ *
 12+ * The following command is used to generate the RTL version of this file
 13+ * ./cssjanus.py --swap_ltr_rtl_in_url < main-ltr.css > main-rtl.css
 14+ */
215 /* Framework */
316 html,
417 body {
——@@ -125,29 +138,36 @@
126139 background-position: bottom right;
127140 background-repeat: no-repeat;
128141 }
 142+ div.vectorTabs li a,
 143+ div.vectorTabs li a span {
 144+ color: #0645ad;
 145+ cursor: pointer;
 146+ }
129147 /* IGNORED BY IE6 */
130148 div.vectorTabs li > a {
131149 display: block;
132150 }
133151 /* OVERRIDDEN BY COMPLIANT BROWSERS */
134152 div.vectorTabs a span {
135 - color: #0645ad;
136153 display: inline-block;
137154 padding-top: 1.25em;
138 - cursor: pointer;
139155 }
140156 /* IGNORED BY IE6 */
141157 div.vectorTabs a > span {
142158 float: left;
143159 display: block;
144160 }
 161+ div.vectorTabs li.selected a,
145162 div.vectorTabs li.selected a span,
 163+ div.vectorTabs li.selected a:visited
146164 div.vectorTabs li.selected a:visited span {
147165 color: #333333;
148166 cursor: default;
149167 text-decoration: none;
150168 }
 169+ div.vectorTabs li.new a,
151170 div.vectorTabs li.new a span,
 171+ div.vectorTabs li.new a:visited,
152172 div.vectorTabs li.new a:visited span {
153173 color: #a55858;
154174 }
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -1,6 +1,6 @@
22 /*
3 - * This file has been automatically generated using CSSJanus, a python script
4 - * for creating RTL versions of otherwise LTR stylesheets.
 3+ * main-rtl.css is automatically generated using CSSJanus, a python script for
 4+ * creating RTL versions of otherwise LTR stylesheets.
55 *
66 * You may download the tool to rebuild this stylesheet
77 * http://code.google.com/p/cssjanus/
——@@ -8,8 +8,8 @@
99 * An online version of this tool can be used at:
1010 * http://cssjanus.commoner.com/
1111 *
12 - * The following options were passed to CSSJanus to build this file properly.
13 - * --swap_ltr_rtl_in_url
 12+ * The following command is used to generate the RTL version of this file
 13+ * ./cssjanus.py --swap_ltr_rtl_in_url < main-ltr.css > main-rtl.css
1414 */
1515 /* Framework */
1616 html,
——@@ -138,33 +138,39 @@
139139 background-position: bottom left;
140140 background-repeat: no-repeat;
141141 }
 142+ div.vectorTabs li a,
 143+ div.vectorTabs li a span {
 144+ color: #0645ad;
 145+ cursor: pointer;
 146+ }
142147 /* IGNORED BY IE6 */
143148 div.vectorTabs li > a {
144149 display: block;
145150 }
146151 /* OVERRIDDEN BY COMPLIANT BROWSERS */
147152 div.vectorTabs a span {
148 - color: #0645ad;
149153 display: inline-block;
150154 padding-top: 1.25em;
151 - cursor: pointer;
152155 }
153156 /* IGNORED BY IE6 */
154157 div.vectorTabs a > span {
155158 float: right;
156159 display: block;
157160 }
 161+ div.vectorTabs li.selected a,
158162 div.vectorTabs li.selected a span,
 163+ div.vectorTabs li.selected a:visited
159164 div.vectorTabs li.selected a:visited span {
160165 color: #333333;
161166 cursor: default;
162167 text-decoration: none;
163168 }
 169+ div.vectorTabs li.new a,
164170 div.vectorTabs li.new a span,
165 - div.vectorTabs li.new a:visited span{
 171+ div.vectorTabs li.new a:visited,
 172+ div.vectorTabs li.new a:visited span {
166173 color: #a55858;
167174 }
168 -
169175 /* Variants and Actions */
170176 div.vectorMenu {
171177 float: right;
——@@ -251,6 +257,7 @@
252258 padding-right: 1.25em;
253259 cursor: default;
254260 border: none;
 261+ font-size: 0.9em;
255262 }
256263 div#panel div.portal div.body {
257264 margin: 0;
——@@ -259,7 +266,6 @@
260267 background-image: url(images/portal-break-rtl.png);
261268 background-repeat: no-repeat;
262269 background-position: top right;
263 - font-size: 0.9em;
264270 }
265271 div#panel div.portal div.body ul {
266272 list-style: none;
——@@ -382,6 +388,7 @@
383389 padding: 0.5em;
384390 text-decoration: none;
385391 background-image: none;
 392+ font-size: 0.9em;
386393 }
387394 #preftoc a:hover {
388395 text-decoration: underline;
——@@ -883,6 +890,7 @@
884891 display: none;
885892 }
886893
 894+
887895 li#pt-userpage,
888896 li#pt-anonuserpage,
889897 li#pt-login {
——@@ -902,46 +910,6 @@
903911 font-size: 95%;
904912 }
905913
906 -/* Classes for EXIF data display */
907 -table.mw_metadata {
908 - font-size: 0.8em;
909 - margin-right: 0.5em;
910 - margin-bottom: 0.5em;
911 - width: 300px;
912 -}
913 -
914 -table.mw_metadata caption {
915 - font-weight: bold;
916 -}
917 -
918 -table.mw_metadata th {
919 - font-weight: normal;
920 -}
921 -
922 -table.mw_metadata td {
923 - padding: 0.1em;
924 -}
925 -
926 -table.mw_metadata {
927 - border: none;
928 - border-collapse: collapse;
929 -}
930 -
931 -table.mw_metadata td, table.mw_metadata th {
932 - text-align: center;
933 - border: 1px solid #aaaaaa;
934 - padding-left: 0.1em;
935 - padding-right: 0.1em;
936 -}
937 -
938 -table.mw_metadata th {
939 - background-color: #f9f9f9;
940 -}
941 -
942 -table.mw_metadata td {
943 - background-color: #fcfcfc;
944 -}
945 -
946914 div#bodyContent {
947915 position: relative;
948916 width: 100%;

Follow-up revisions

RevisionCommit summaryAuthorDate
r53410Merging UI fixes from trunk; second batch from http://www.mediawiki.org/wiki/......brion18:05, 17 July 2009

Status & tagging log