r53180 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53179‎ | r53180 | r53181 >
Date:17:13, 13 July 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Backported r53159 to 1.14 and 1.15
Modified paths:
  • /branches/REL1_14/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_14/phase3/includes/specials/SpecialBlockip.php (modified) (history)
  • /branches/REL1_15/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_15/phase3/includes/specials/SpecialBlockip.php (modified) (history)

Diff [purge]

Index: branches/REL1_14/phase3/includes/specials/SpecialBlockip.php
@@ -525,7 +525,7 @@
526526 */
527527 private function getContribsLink( $skin ) {
528528 $contribsPage = SpecialPage::getTitleFor( 'Contributions', $this->BlockAddress );
529 - return $skin->link( $contribsPage, wfMsgHtml( 'ipb-blocklist-contribs', $this->BlockAddress ) );
 529+ return $skin->link( $contribsPage, wfMsgExt( 'ipb-blocklist-contribs', 'escape', $this->BlockAddress ) );
530530 }
531531
532532 /**
Index: branches/REL1_14/phase3/RELEASE-NOTES
@@ -33,6 +33,7 @@
3434 * (bug 17832) Fixed action=delete returning 'unknownerror' instead of
3535 'permissiondenied' when the user is blocked
3636 * Fixed performance regression when accessing deleted (archived) files
 37+* (bug 19693) Fixed cross-site scripting vulnerability in Special:Block
3738
3839 == Changes since 1.14.0rc1 ==
3940
Index: branches/REL1_15/phase3/includes/specials/SpecialBlockip.php
@@ -632,7 +632,7 @@
633633 */
634634 private function getContribsLink( $skin ) {
635635 $contribsPage = SpecialPage::getTitleFor( 'Contributions', $this->BlockAddress );
636 - return $skin->link( $contribsPage, wfMsgHtml( 'ipb-blocklist-contribs', $this->BlockAddress ) );
 636+ return $skin->link( $contribsPage, wfMsgExt( 'ipb-blocklist-contribs', 'escape', $this->BlockAddress ) );
637637 }
638638
639639 /**
Index: branches/REL1_15/phase3/RELEASE-NOTES
@@ -26,6 +26,7 @@
2727 ForeignAPIRepo.
2828 * Fixed the "change password" link on Special:Preferences to have the correct
2929 returnto parameter.
 30+* (bug 19693) Fixed cross-site scripting vulnerability in Special:Block
3031
3132 === Changes since 1.15.0rc1 ===
3233

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53159(bug 19693) escape user link in contribution linkialex09:42, 13 July 2009

Status & tagging log