r53168 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53167‎ | r53168 | r53169 >
Date:14:54, 13 July 2009
Author:mrzman
Status:ok
Tags:
Comment:
Followup to r53087 / r53052 - Change dieUsage to setWarning per CodeReview
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryCategoryMembers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryCategoryMembers.php
@@ -87,10 +87,10 @@
8888 # how to have efficient subcategory access :-) ~~~~ (oh well, domas)
8989 global $wgMiserMode;
9090 if ( $wgMiserMode && isset($params['namespace']) ) {
91 - $this->dieUsage("The cmnamespace option is disabled on this site", 'namespacedisabled');
 91+ $this->setWarning("The cmnamespace option is disabled on this site");
 92+ } else {
 93+ $this->addWhereFld('page_namespace', $params['namespace']);
9294 }
93 - $this->addWhereFld('page_namespace', $params['namespace']);
94 -
9595 if($params['sort'] == 'timestamp')
9696 $this->addWhereRange('cl_timestamp', ($params['dir'] == 'asc' ? 'newer' : 'older'), $params['start'], $params['end']);
9797 else

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r53052don't allow querying specific namespace if misermode is enabledmidom13:55, 10 July 2009
r53087Followup to r53052 - Die if someone tries to use the namespace filter, rather...mrzman23:46, 10 July 2009

Status & tagging log