r53045 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r53044‎ | r53045 | r53046 >
Date:12:16, 10 July 2009
Author:tstarling
Status:deferred
Tags:
Comment:
Revert r52564, arbitrary script inclusion vulnerability.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.php
@@ -22,19 +22,6 @@
2323 // Set this to true to simply override the stock toolbar for everyone
2424 $wgUsabilityInitiativeCoesxistWithMvEmbed = false;
2525
26 -// Configures which modules should be enabled
27 -if (
28 - !isset( $wgUsabilityInitiativeModules ) ||
29 - !is_array( $wgUsabilityInitiativeModules )
30 -) {
31 - $wgUsabilityInitiativeModules = array(
32 - 'EditToolbar',
33 - 'EditWarning',
34 - 'PrefStats',
35 - 'OptIn'
36 - );
37 -}
38 -
3926 /* Setup */
4027
4128 // Sets Credits
@@ -55,10 +42,11 @@
5643 $wgExtensionMessagesFiles['UsabilityInitiative'] =
5744 dirname( __FILE__ ) . "/UsabilityInitiative.i18n.php";
5845
59 -// Includes modules
60 -foreach ( $wgUsabilityInitiativeModules as $module ) {
61 - require_once( dirname( __FILE__ ) . "/{$module}/{$module}.php" );
62 -}
 46+// Includes sub-extensions
 47+require_once( dirname( __FILE__ ) . "/EditToolbar/EditToolbar.php" );
 48+require_once( dirname( __FILE__ ) . "/EditWarning/EditWarning.php" );
 49+require_once( dirname( __FILE__ ) . "/PrefStats/PrefStats.php" );
 50+require_once( dirname( __FILE__ ) . "/OptIn/OptIn.php" );
6351
6452 // Registers Hooks
6553 $wgHooks['AjaxAddScript'][] = 'UsabilityInitiativeHooks::addJs';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52564Made modules configurable.tparscal19:00, 29 June 2009

Status & tagging log