r52956 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52955‎ | r52956 | r52957 >
Date:01:04, 9 July 2009
Author:simetrical
Status:ok
Tags:
Comment:
Remove redundant no-op implementations

Followup to r52951.
Modified paths:
  • /trunk/phase3/includes/db/DatabaseIbm_db2.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseMssql.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)
  • /trunk/phase3/includes/db/DatabasePostgres.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -1073,8 +1073,4 @@
10741074 public function getSearchEngine() {
10751075 return "SearchOracle";
10761076 }
1077 -
1078 - /** No-op */
1079 - public function setBigSelects( $value = true ) {}
1080 -
10811077 } // end DatabaseOracle class
Index: trunk/phase3/includes/db/DatabasePostgres.php
@@ -1400,9 +1400,6 @@
14011401 return "SearchPostgres";
14021402 }
14031403
1404 - /** No-op */
1405 - public function setBigSelects( $value = true ) {}
1406 -
14071404 /** Todo: maybe implement this? */
14081405 public function lockTables( $read, $write, $method ) {}
14091406
Index: trunk/phase3/includes/db/DatabaseIbm_db2.php
@@ -1750,8 +1750,4 @@
17511751 // TODO
17521752 // see SpecialAncientpages
17531753 }
1754 -
1755 - /** No-op */
1756 - public function setBigSelects( $value = true ) {}
17571754 }
1758 -?>
Index: trunk/phase3/includes/db/DatabaseMssql.php
@@ -985,9 +985,6 @@
986986 public function getSearchEngine() {
987987 return "SearchEngineDummy";
988988 }
989 -
990 - /** No-op */
991 - public function setBigSelects( $value = true ) {}
992989 }
993990
994991 /**
Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -452,9 +452,6 @@
453453 return $s;
454454 }
455455
456 - /** No-op */
457 - public function setBigSelects( $value = true ) {}
458 -
459456 public function lockTables( $read, $write, $method ) {}
460457
461458 public function unlockTables( $method ) {}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52951(bug 19591) Move setBigSelects() to DatabaseMysqldemon00:14, 9 July 2009

Status & tagging log