r52925 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r52924‎ | r52925 | r52926 >
Date:17:09, 8 July 2009
Author:ialex
Status:ok
Tags:
Comment:
fix for r52864: PHP Strict Standards: Declaration of SkinStandard::getHeadScripts() should be compatible with that of Skin::getHeadScripts() in includes/Skin.php on line 141
Modified paths:
  • /trunk/phase3/skins/Standard.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Standard.php
——@@ -18,10 +18,10 @@
1919 /**
2020 *
2121 */
22 - function getHeadScripts( $allowUserJs ) {
 22+ function getHeadScripts( $allowUserJs, $extraHtml = '' ) {
2323 global $wgStylePath, $wgJsMimeType, $wgStyleVersion;
2424
25 - $s = parent::getHeadScripts( $allowUserJs );
 25+ $s = parent::getHeadScripts( $allowUserJs, $extraHtml );
2626 if ( 3 == $this->qbSetting() ) { # Floating left
2727 $s .= "<script language='javascript' type='$wgJsMimeType' " .
2828 "src='{$wgStylePath}/common/sticky.js?$wgStyleVersion'></script>\n";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52864Unify MonoBook <head> generation with legacy skins...simetrical21:49, 7 July 2009

Status & tagging log