r52844 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52843‎ | r52844 | r52845 >
Date:16:52, 7 July 2009
Author:ashley
Status:ok
Tags:
Comment:
SocialProfile: fixes for UserActivity
Modified paths:
  • /trunk/extensions/SocialProfile/UserActivity/UserActivity.i18n.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserActivity/UserActivityClass.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserActivity/UserActivity.i18n.php
@@ -13,7 +13,7 @@
1414 * @author David Pean
1515 */
1616 $messages['en'] = array(
17 - 'useractivity' => 'Friends activity',
 17+ 'useractivity' => "Friends' activity",
1818 'useractivity-award' => 'received an award', // FIXME: message lego
1919 'useractivity-all' => 'View all',
2020 'useractivity-gift' => 'received a gift from', // FIXME: message logo
@@ -23,7 +23,7 @@
2424 'useractivity-group-friend' => 'friends',
2525 'useractivity-filter' => 'Filter',
2626 'useractivity-network-thought' => 'has a thought for the $1 network', // FIXME: message lego
27 - 'useractivity-title' => "Friends activity",
 27+ 'useractivity-title' => "Friends' activity",
2828 'useractivity-siteactivity' => 'Site activity',
2929 'useractivity-edit' => '{{PLURAL:$1|edited the page|edited the following pages: }}', // CHECKME: message lego?
3030 'useractivity-comment' => '{{PLURAL:$1|commented on the page|commented on the following pages: }}', // CHECKME: message lego?
Index: trunk/extensions/SocialProfile/UserActivity/UserActivityClass.php
@@ -719,7 +719,7 @@
720720
721721 if ( $pages )
722722 $pages .= ", ";
723 - $pages .= " <a href=\"{$page_title2->escapeFullURL()}\">{$page_name2}</a>";
 723+ $pages .= ( ( $page_title2 instanceOf Title ) ? " <a href=\"{$page_title2->escapeFullURL()}\">{$page_name2}</a>" : '' );
724724 if ( $count_actions2 > 1 ) {
725725 $pages .= " ($count_actions2 " . wfMsg( "useractivity-group-{$type}" ) . ")";
726726 }

Status & tagging log