r5283 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r5282‎ | r5283 | r5284 >
Date:23:08, 17 September 2004
Author:hashar
Status:old
Tags:
Comment:
Stop loading feed.php every time by moving available feeds classes in defines.php and removing call from skin.php
Modified paths:
  • /trunk/phase3/includes/Defines.php (modified) (history)
  • /trunk/phase3/includes/Feed.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Defines.php
@@ -52,4 +52,14 @@
5353 define('NS_WIKIPEDIA', NS_PROJECT);
5454 define('NS_WIKIPEDIA_TALK', NS_PROJECT_TALK);
5555 /**#@-*/
 56+
 57+/**
 58+ * Available feeds objects
 59+ * Should probably only be defined when a page is syndicated ie when
 60+ * $wgOut->isSyndicated() is true
 61+ */
 62+$wgFeedClasses = array(
 63+ 'rss' => 'RSSFeed',
 64+ 'atom' => 'AtomFeed',
 65+ );
5666 ?>
Index: trunk/phase3/includes/Feed.php
@@ -22,16 +22,10 @@
2323
2424 /**
2525 * Contain a feed class as well as classes to build rss / atom ... feeds
 26+ * Available feeds are defined in Defines.php
2627 * @package MediaWiki
2728 */
2829
29 -/**
30 - * Available feeds objects
31 - */
32 -$wgFeedClasses = array(
33 - 'rss' => 'RSSFeed',
34 - 'atom' => 'AtomFeed',
35 - );
3630
3731 /**
3832 * @todo document
Index: trunk/phase3/includes/Skin.php
@@ -11,8 +11,6 @@
1212 if( defined( "MEDIAWIKI" ) ) {
1313
1414 # See skin.doc
15 -
16 -require_once( 'Feed.php' ); // should not be called if the actual page isn't feed enabled
1715 require_once( 'Image.php' );
1816
1917 # These are the INTERNAL names, which get mapped directly to class names and

Status & tagging log