r52811 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52810‎ | r52811 | r52812 >
Date:22:53, 6 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Fixes what r52810 broke, making other tabs have the correct XML IDs
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -374,14 +374,12 @@
375375 foreach ( $nav as $section => $links ) {
376376 foreach ( $links as $key => $link ) {
377377 $xmlID = $key;
378 - if ( isset( $link['context'] ) ) {
379 - if ( $link['context'] == 'subject' ) {
380 - $xmlID = 'ca-nstab-' . $xmlID;
381 - } else if ( $link['context'] == 'talk' ) {
382 - $xmlID = 'ca-talk';
383 - } else {
384 - $xmlID = 'ca-' . $xmlID;
385 - }
 378+ if ( isset( $link['context'] ) && $link['context'] == 'subject' ) {
 379+ $xmlID = 'ca-nstab-' . $xmlID;
 380+ } else if ( isset( $link['context'] ) && $link['context'] == 'talk' ) {
 381+ $xmlID = 'ca-talk';
 382+ } else {
 383+ $xmlID = 'ca-' . $xmlID;
386384 }
387385 $nav[$section][$key]['attributes'] =
388386 ' id="' . Sanitizer::escapeId( $xmlID ) . '"';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52810Actually resolves namespaces and tabs having the correct XML IDstparscal22:51, 6 July 2009

Status & tagging log