r52809 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52808‎ | r52809 | r52810 >
Date:22:45, 6 July 2009
Author:tparscal
Status:ok
Tags:
Comment:
Resolves talk namespace tab having the wrong XML id
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -374,8 +374,13 @@
375375 foreach ( $nav as $section => $links ) {
376376 foreach ( $links as $key => $link ) {
377377 $insert = '';
378 - if ( isset( $link['context'] ) && $link['context'] == 'subject' ) {
379 - $insert = 'nstab-';
 378+ if ( isset( $link['context'] ) ) {
 379+ if ( $link['context'] == 'subject' ) {
 380+ $insert = 'nstab-';
 381+ }
 382+ if ( $link['context'] == 'talk' ) {
 383+ $key = 'talk';
 384+ }
380385 }
381386 $nav[$section][$key]['attributes'] =
382387 ' id="' . Sanitizer::escapeId( "ca-{$insert}{$key}" ) . '"';

Status & tagging log