r52697 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r52696‎ | r52697 | r52698 >
Date:15:24, 2 July 2009
Author:ialex
Status:ok
Tags:
Comment:
Xml::element() -> Xml::tags() since the content is already parsed.

Note: escaping parsed content breaks french typo since spaces before ;:?! are automatically converted to &nbsp; by Parser::parse() and will be viewable by end-users if they're escaped.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
——@@ -766,7 +766,7 @@
767767 array( 'id' => 'mw-searchoptions', 'style' => 'margin:0em;' )
768768 ) .
769769 Xml::element( 'legend', null, wfMsg('powersearch-legend') ) .
770 - Xml::element( 'h4', null, wfMsgExt( 'powersearch-ns', array( 'parseinline' ) ) ) .
 770+ Xml::tags( 'h4', null, wfMsgExt( 'powersearch-ns', array( 'parseinline' ) ) ) .
771771 Xml::tags(
772772 'div',
773773 array( 'id' => 'mw-search-togglebox' ),

Status & tagging log