r52692 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52691‎ | r52692 | r52693 >
Date:13:57, 2 July 2009
Author:jojo
Status:deferred
Tags:
Comment:
fix: use another name for the jQuery variable, in case jQuery by s.th. else w/out noConflict()
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)
  • /trunk/extensions/Collection/collection/collection.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/collection/collection.js
@@ -21,6 +21,8 @@
2222
2323 (function() {
2424
 25+var jQuery = collection_jQuery;
 26+
2527 /******************************************************************************/
2628
2729 var requiredVersion = '1.2';
Index: trunk/extensions/Collection/Collection.body.php
@@ -265,7 +265,7 @@
266266 $wgOut->addInlineScript( "var wgCollectionVersion = \"$wgCollectionVersion\";" );
267267 $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/jquery.js?$wgCollectionStyleVersion\"></script>" );
268268 $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/jquery.ui.js?$wgCollectionStyleVersion\"></script>" );
269 - $wgOut->addInlineScript( "jQuery.noConflict();" );
 269+ $wgOut->addInlineScript( "var collection_jQuery = jQuery.noConflict();" );
270270 $wgOut->addScript( "<script type=\"$wgJsMimeType\" src=\"$wgScriptPath/extensions/Collection/collection/collection.js?$wgCollectionStyleVersion\"></script>" );
271271
272272 $template = new CollectionPageTemplate();

Status & tagging log