r5269 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r5268‎ | r5269 | r5270 >
Date:16:31, 17 September 2004
Author:hashar
Status:old
Tags:
Comment:
Fix bug http://bugzilla.wikipedia.org/show_bug.cgi?id=502 . Implement allow quickbar suppression in PHPTal skins, error pages suppress quickbars
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/SkinPHPTal.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -20,6 +20,7 @@
2121 * Skins system more modular: templates and CSS are now in /skins/
2222 * New user preference for limitting the image size for images on image description
2323 pages
 24+* Error pages no more offer edit / talk / watch links (bug #502)
2425 * ... and more!
2526
2627 === Caveats ===
Index: trunk/phase3/includes/SkinPHPTal.php
@@ -358,14 +358,14 @@
359359 * an array of edit links by default used for the tabs
360360 */
361361 function buildContentActionUrls () {
362 - global $wgTitle, $wgUser, $wgRequest, $wgUseValidation;
 362+ global $wgTitle, $wgUser, $wgOut, $wgRequest, $wgUseValidation;
363363 $action = $wgRequest->getText( 'action' );
364364 $section = $wgRequest->getText( 'section' );
365365 $oldid = $wgRequest->getVal( 'oldid' );
366366 $diff = $wgRequest->getVal( 'diff' );
367367 $content_actions = array();
368368
369 - if( $this->iscontent ) {
 369+ if( $this->iscontent and !$wgOut->isQuickbarSuppressed() ) {
370370
371371 $nskey = $this->getNameSpaceKey();
372372 $is_active = !Namespace::isTalk( $wgTitle->getNamespace()) ;
Index: trunk/phase3/includes/OutputPage.php
@@ -1,6 +1,6 @@
22 <?php
33 /**
4 - * $Id$
 4+ * @version $Id$
55 * @package MediaWiki
66 */
77
@@ -506,6 +506,8 @@
507507 $this->setHTMLTitle( wfMsg( 'errorpagetitle' ) );
508508 $this->setRobotpolicy( 'noindex,nofollow' );
509509 $this->setArticleRelated( false );
 510+ $this->suppressQuickbar();
 511+
510512 $this->enableClientCache( false );
511513 $this->mRedirect = '';
512514

Status & tagging log