r52684 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r52683‎ | r52684 | r52685 >
Date:10:02, 2 July 2009
Author:rainman
Status:ok
Tags:
Comment:
Should always close the form here since it apparently is not closed in advanced.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -225,8 +225,8 @@
226226 $wgOut->addHTML( $this->formHeader($term, 0, 0));
227227 if( $this->searchAdvanced ) {
228228 $wgOut->addHTML( $this->powerSearchBox( $term ) );
229 - } else
230 - $wgOut->addHTML( '</form>' );
 229+ }
 230+ $wgOut->addHTML( '</form>' );
231231 // Empty query -- straight view of search form
232232 wfProfileOut( __METHOD__ );
233233 return;

Status & tagging log